RE: Listeners buckets and duplication w/ and w/o SO_REUSEPORT on trunk

2014-10-18 Thread Lu, Yingqi
Hi All, I just want to check if there is any feedback on this? Generated based on trunk version, this is to remove some code duplications/global variables. This also removes listener duplication when SO_REUSEPORT is not being used. For details, please refer to Yann Ylavic's notes and my respon

Re: svn commit: r1632736 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS modules/proxy/mod_proxy_http.c

2014-10-18 Thread Yann Ylavic
Done in r1632740 and r1632742. Backport proposed in r1632744. Thanks, Yann. On Sat, Oct 18, 2014 at 9:28 AM, Yann Ylavic wrote: > Hi Christophe, > > On Sat, Oct 18, 2014 at 9:20 AM, Marion & Christophe JAILLET > wrote: >> Hi, >> >> Isn't there the same kind of potential issue in: >> mod_bu

Re: svn commit: r1632736 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS modules/proxy/mod_proxy_http.c

2014-10-18 Thread Yann Ylavic
Hi Christophe, On Sat, Oct 18, 2014 at 9:20 AM, Marion & Christophe JAILLET wrote: > Hi, > > Isn't there the same kind of potential issue in: > mod_buffer, line 268 > mod_cahce, line 687 Yes both, good catches. Do you want/plan to fix them? Regards, Yann.

Re: svn commit: r1632736 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS modules/proxy/mod_proxy_http.c

2014-10-18 Thread Marion & Christophe JAILLET
Hi, Isn't there the same kind of potential issue in: mod_buffer, line 268 mod_cahce, line 687 Best regards, CJ Le 18/10/2014 08:57, jaillet...@apache.org a écrit : Author: jailletc36 Date: Sat Oct 18 06:57:40 2014 New Revision: 1632736 URL: http://svn.apache.org/r1632736 Log: Merge r