Bug in mod_proxvy_fdpass?

2015-11-27 Thread Christophe JAILLET
Hi, smatch compains that: /modules/proxy/mod_proxy_fdpass.c:152 proxy_fdpass_handler() warn: this array is probably non-NULL. 'worker->s->flusher' I think that: const char *flush_method = worker->s->flusher ? worker->s->flusher : "flush"; should be turned into: const

RE: No H2 Window updates!

2015-11-27 Thread Bert Huijben
Well… it is not a regression, so can it be a show stopper? ☺… But I would like to see this fixed. I have no idea how hard it would be to fix this though. It could be as simple as removing that config line (which was probably added somewhere early on if I look at that comment). But windowing

Re: No H2 Window updates!

2015-11-27 Thread Jim Jagielski
Hmmm... this seems to me enough to warrant a hold on my T until we dig into this deeper.

No H2 Window updates!

2015-11-27 Thread Bert Huijben
Hi, I finally took the time to diagnose that segfault I had, and I think it points to a serious bug in httpd. To summarize this: I don't receive window updates. In this specific test we set a very huge amount of small requests (bodies of 95 and 113 bytes), until we get

RE: No H2 Window updates!

2015-11-27 Thread Bert Huijben
> -Original Message- > From: Bert Huijben [mailto:b...@qqmail.nl] > Sent: vrijdag 27 november 2015 13:56 > To: b...@qqmail.nl > Subject: > >     Hi, > > I finally took the time to diagnose that segfault I had, and I think it > points to a serious bug in httpd. > > To

Re: No H2 Window updates!

2015-11-27 Thread Jan Ehrhardt
Bert Huijben in gmane.comp.apache.devel (Fri, 27 Nov 2015 20:04:14 +0100): >Well… it is not a regression, so can it be a show stopper? ?… >But I would like to see this fixed. Curious: are you still testing this on Windows? If so, I guess you compiled your own httpd. I tried to do the same a

Re: No H2 Window updates!

2015-11-27 Thread Jan Ehrhardt
Jan Ehrhardt in gmane.comp.apache.devel (Fri, 27 Nov 2015 22:34:53 +0100): >Bert Huijben in gmane.comp.apache.devel (Fri, 27 Nov 2015 20:04:14 +0100): >>Well… it is not a regression, so can it be a show stopper? ?… >>But I would like to see this fixed. > >Curious: are you still testing this on