Woah, quite a patch! Tested on OS X 15.4 and all framework/trunk
and mod_h2/trunk tests pass.
Tried to move SSLProxyEngine into the <Proxy> configs. Worked like
a charm, both when needed and when not. When it was missing I
properly got an internal server error and log:
AH01961: SSL Proxy requested for test.example.org:443 but not enabled [Hint:
SSLProxyEngine]
So, a go ahead from me. Nice work.
-Stefan
PS. IANAMSE (I am not a mod_ssl expert), but I get the feeling that
the addition of a mod_ssl_proxy which can keep its own config record
*might* be worth considering at some point in time.
> Am 21.04.2016 um 20:51 schrieb Yann Ylavic <ylavic....@gmail.com>:
>
> On Thu, Apr 21, 2016 at 9:31 AM, Stefan Eissing
> <stefan.eiss...@greenbytes.de> wrote:
>> Not in today, but will have a look tomorrow.
>
> On Thu, Apr 21, 2016 at 10:53 AM, Rainer Jung <rainer.j...@kippdata.de> wrote:
>> It'll take me a few days, likely over the weekend. Thanks a bunch already.
>
> Thanks Stefan and Rainer.
>
> Here is a v3 which passes the tests framework, the previous ones
> didn't because of issues in "ssl_proxy_{enable,disable}_ex()", now
> fixed and also renamed/unified into a single "ssl_engine_set(c,
> per_dir_config, server/proxy, on/off)" function.
>
> I'll add more framework tests (per <Proxy>) once/if committed.
>
> Regards,
> Yann.
> <SSLProxy-v3.patch>
