Re: Frequent wake-ups for mpm_event

2016-08-18 Thread Yann Ylavic
On Thu, Aug 18, 2016 at 3:53 PM, Plüm, Rüdiger, Vodafone Group wrote: > > From a brief view looks good, but you miss to adjust ps->keep_alive in case > that keepalives are killed due to busy workers. Thanks for the review, fixed in the version I'm currently testing.

Re: svn commit: r1756649 - in /httpd/httpd/trunk: docs/manual/mod/core.xml server/core.c

2016-08-18 Thread William A Rowe Jr
+1 On Aug 18, 2016 2:25 PM, "Christophe JAILLET" wrote: > HttpProtocolOptions (in code) or HTTPProtocolOptions (in doc) > > This should be consistent, and I'm +1 for HttpProtocolOptions. > > CJ > > Le 17/08/2016 à 18:24, wr...@apache.org a écrit : > >> Author:

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-08-18 Thread William A Rowe Jr
On Thu, Aug 18, 2016 at 5:00 AM, William A Rowe Jr wrote: > Just FWIW, this still is not fixed for the legacy header parser. > > It *is* now fixed for the HTTP Request Line parser. Relaxing the > whitespace rule (as we still do by default) only lets 1+ SP/HTAB > slip

Re: svn commit: r1756649 - in /httpd/httpd/trunk: docs/manual/mod/core.xml server/core.c

2016-08-18 Thread Christophe JAILLET
HttpProtocolOptions (in code) or HTTPProtocolOptions (in doc) This should be consistent, and I'm +1 for HttpProtocolOptions. CJ Le 17/08/2016 à 18:24, wr...@apache.org a écrit : Author: wrowe Date: Wed Aug 17 16:24:23 2016 New Revision: 1756649 URL:

--enable-maintainer-mode conflict

2016-08-18 Thread William A Rowe Jr
I'm wondering if we would agree that a new flag, such as --enable-httpd-maintainer-mode would let us disambiguate our flag from the automake built-in flag, at least for trunk? Thoughts or alternate suggestions?

Re: svn commit: r1756556 - /httpd/httpd/branches/2.4.x/STATUS

2016-08-18 Thread Jacob Champion
On 08/18/2016 04:11 AM, Yann Ylavic wrote: On Wed, Aug 17, 2016 at 7:08 PM, Jacob Champion wrote: What's the procedure for dealing with this in STATUS when I propose something? A 2.4.x patch hosted... somewhere? Yes, you can propose a branch merge in a standalone

Re: svn commit: r1756729 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h server/core.c server/protocol.c

2016-08-18 Thread Ruediger Pluem
On 08/18/2016 09:15 AM, wr...@apache.org wrote: > Author: wrowe > Date: Thu Aug 18 07:15:06 2016 > New Revision: 1756729 > > URL: http://svn.apache.org/viewvc?rev=1756729=rev > Log: > Perform correct, strict parsing of the request line, handling the > http protocol tag, url and method

AW: Frequent wake-ups for mpm_event

2016-08-18 Thread Plüm , Rüdiger , Vodafone Group
> -Ursprüngliche Nachricht- > Von: Yann Ylavic [mailto:ylavic@gmail.com] > Gesendet: Donnerstag, 18. August 2016 15:17 > An: httpd-dev > Betreff: Re: Frequent wake-ups for mpm_event > > On Thu, Aug 18, 2016 at 11:04 AM, Plüm, Rüdiger, Vodafone Group >

Re: Frequent wake-ups for mpm_event

2016-08-18 Thread Yann Ylavic
On Thu, Aug 18, 2016 at 11:04 AM, Plüm, Rüdiger, Vodafone Group wrote: > > From: Luca Toscano [mailto:toscano.l...@gmail.com] > Sent: Freitag, 12. August 2016 15:42 > To: Apache HTTP Server Development List > Subject: Re: Frequent wake-ups for mpm_event > >> This

Re: svn commit: r1756561 - in /httpd/httpd/branches/2.4.x: ./ CHANGES STATUS include/ap_mmn.h modules/dav/main/mod_dav.c modules/dav/main/mod_dav.h

2016-08-18 Thread Yann Ylavic
On Wed, Aug 17, 2016 at 5:18 PM, Ruediger Pluem wrote: > > This causes 2.4 fail to compile because r1748155 is missing from the backport. Thanks Rüdiger, I missed it (not using clang). Just added r1748155 to existing r1756560's follow up. Regards, Yann.

Re: svn commit: r1756556 - /httpd/httpd/branches/2.4.x/STATUS

2016-08-18 Thread Yann Ylavic
On Wed, Aug 17, 2016 at 7:08 PM, Jacob Champion wrote: > > What's the procedure for dealing with this in STATUS when I propose > something? A 2.4.x patch hosted... somewhere? Yes, you can propose a branch merge in a standalone patch, and give a link to it in a "2.4.x patch:

RE: svn commit: r1756556 - /httpd/httpd/branches/2.4.x/STATUS

2016-08-18 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Jacob Champion [mailto:champio...@gmail.com] > Sent: Mittwoch, 17. August 2016 19:09 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1756556 - /httpd/httpd/branches/2.4.x/STATUS > > On 08/16/2016 03:29 PM, yla...@apache.org wrote: > >*) autoconf:

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-08-18 Thread William A Rowe Jr
Just FWIW, this still is not fixed for the legacy header parser. It *is* now fixed for the HTTP Request Line parser. Relaxing the whitespace rule (as we still do by default) only lets 1+ SP/HTAB slip through, and then recomposes with single SP delimiters. Of the subset \f \r \v \n I can't think

Re: HTTP/1.1 strict ruleset

2016-08-18 Thread William A Rowe Jr
On Thu, Aug 18, 2016 at 4:26 AM, Plüm, Rüdiger, Vodafone Group < ruediger.pl...@vodafone.com> wrote: > > > -Original Message- > > From: Yann Ylavic [mailto:ylavic@gmail.com] > > Sent: Donnerstag, 11. August 2016 22:40 > > To: httpd-dev > > Subject: Re: HTTP/1.1 strict ruleset > > > >

RE: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-08-18 Thread Plüm , Rüdiger , Vodafone Group
+1 Regards Rüdiger > -Original Message- > From: Jacob Champion [mailto:champio...@gmail.com] > Sent: Donnerstag, 4. August 2016 22:35 > To: dev@httpd.apache.org > Subject: Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c > > On 08/04/2016 01:11 PM, William A Rowe Jr

RE: HTTP/1.1 strict ruleset

2016-08-18 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: Yann Ylavic [mailto:ylavic@gmail.com] > Sent: Donnerstag, 11. August 2016 22:40 > To: httpd-dev > Subject: Re: HTTP/1.1 strict ruleset > > On Thu, Aug 11, 2016 at 6:56 PM, William A Rowe Jr > wrote: > > > > I haven't dug terribly

RE: Frequent wake-ups for mpm_event

2016-08-18 Thread Plüm , Rüdiger , Vodafone Group
From: Luca Toscano [mailto:toscano.l...@gmail.com] Sent: Freitag, 12. August 2016 15:42 To: Apache HTTP Server Development List Subject: Re: Frequent wake-ups for mpm_event This patch might also miss another point, namely the calls to process_timeout_queue to manage Keep Alive timeouts,