Re: Frequent wake-ups for mpm_event

2016-08-20 Thread Yann Ylavic
On Thu, Aug 18, 2016 at 3:17 PM, Yann Ylavic wrote: > > I was thinking of something like the attached patch, where we compute > the exact/minimal timeout needed for the queues. > > It requires walking/locking the queues (looking at the first item > only), but besides getting

Re: Question re: build of (64-bit) httpd and issue with apr_password_validate

2016-08-20 Thread Michael Felt
On 8/19/2016 3:03 PM, Eric Covener wrote: On Fri, Aug 19, 2016 at 7:14 AM, Michael Felt wrote: root@x064:[/data/prj/apache/httpd-2.4.23]nm /opt/modules/mod_authn_file.so | grep apr_password_validate Are you sure that the libapr you're scrutinizing is being loaded at

Re: State of trunk --enable-modules=reallyall build

2016-08-20 Thread William A Rowe Jr
On Fri, Aug 19, 2016 at 8:17 PM, William A Rowe Jr wrote: > On Fri, Aug 19, 2016 at 6:14 PM, Yann Ylavic wrote: > >> >> How couldn't it figure out that apr_pstrcat() never returns NULL? >> Clever compilers should really read all the docs :) >> > > :) >

Re: Question about atomic in "mpm/worker/fdqueue.c"

2016-08-20 Thread Yann Ylavic
On Sat, Aug 20, 2016 at 9:34 AM, Christophe JAILLET wrote: > Hi, > > shouldn't "queue_info->idlers" on line 138 of "mpm/worker/fdqueue.c" be read > using "apr_atomic_read32" ? Actually both apr_atomic_read32() and current volatile declaration are racy here,

Re: Question re: build of (64-bit) httpd and issue with apr_password_validate

2016-08-20 Thread Michael Felt
On 8/19/2016 3:03 PM, Eric Covener wrote: On Fri, Aug 19, 2016 at 7:14 AM, Michael Felt wrote: root@x064:[/data/prj/apache/httpd-2.4.23]nm /opt/modules/mod_authn_file.so | grep apr_password_validate Are you sure that the libapr you're scrutinizing is being loaded at

Question about atomic in "mpm/worker/fdqueue.c"

2016-08-20 Thread Christophe JAILLET
Hi, shouldn't "queue_info->idlers" on line 138 of "mpm/worker/fdqueue.c" be read using "apr_atomic_read32" ? CJ --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus