Re: [RFC] fixing mod_cgid error logging

2019-07-05 Thread Joe Orton
On Fri, Jul 05, 2019 at 01:39:21PM +0200, Ruediger Pluem wrote: > How much portable is this and do we have / should have something in > APR that does that portability? We probably should guard this with a > check for > > #ifndef CMSG_DATA > #error This module only works on unix platforms with th

Re: [RFC] fixing mod_cgid error logging

2019-07-05 Thread Ruediger Pluem
On 07/05/2019 12:57 PM, Joe Orton wrote: > PR 54211 and 60692 track a design problem in mod_cgid: the stderr of > spawned CGI scripts is a copy of the main server's stderr. This is a > significant regression from mod_cgi (you lose logging prefixes, > per-vhost config, non-file/pipe-logging p

Re: [RFC] fixing mod_cgid error logging

2019-07-05 Thread Stefan Eissing
No objections from me, as I lack the expertise here. Patch looks readable, though. ;) > Am 05.07.2019 um 12:57 schrieb Joe Orton : > > PR 54211 and 60692 track a design problem in mod_cgid: the stderr of > spawned CGI scripts is a copy of the main server's stderr. This is a > significant regr

[RFC] fixing mod_cgid error logging

2019-07-05 Thread Joe Orton
PR 54211 and 60692 track a design problem in mod_cgid: the stderr of spawned CGI scripts is a copy of the main server's stderr. This is a significant regression from mod_cgi (you lose logging prefixes, per-vhost config, non-file/pipe-logging provider support e.g. syslog) I can think of two mai

Re: svn commit: r1862475 - in /httpd/httpd/trunk: CHANGES modules/http2/h2_conn.c modules/http2/h2_version.h server/mpm/event/event.c

2019-07-05 Thread Ruediger Pluem
On 07/03/2019 11:13 PM, Yann Ylavic wrote: > On Wed, Jul 3, 2019 at 6:38 PM Ruediger Pluem wrote: >> >> On 07/03/2019 03:46 PM, ic...@apache.org wrote: >>> >>> -if (pending == OK) { >>> +if (pending == OK || (pending == DECLINED && >>> + cs->pub.sens