Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Ruediger Pluem
On 4/1/20 11:44 PM, Mike Rumph wrote: > I'm not very familiar with this code, so my questions might not make sense. > > But take a look at the following two code segments in > ssl_io_filter_coalesce(): > >     for (e = APR_BRIGADE_FIRST(bb); >          e != APR_BRIGADE_SENTINEL(bb) >        

Re: svn commit: r1875947 - in /httpd/httpd/trunk: include/http_request.h modules/http/http_core.c modules/http/http_request.c server/core.c server/core_filters.c server/request.c server/util_filter.c

2020-04-01 Thread Ruediger Pluem
On 3/31/20 6:22 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 31 16:22:53 2020 > New Revision: 1875947 > > URL: http://svn.apache.org/viewvc?rev=1875947&view=rev > Log: > core: handle morphing buckets setaside/reinstate and kill request core filter. > > The purpose of ap_reques

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Mike Rumph
I'm not very familiar with this code, so my questions might not make sense. But take a look at the following two code segments in ssl_io_filter_coalesce(): for (e = APR_BRIGADE_FIRST(bb); e != APR_BRIGADE_SENTINEL(bb) && !APR_BUCKET_IS_METADATA(e) && e->leng

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Ruediger Pluem
On 4/1/20 2:38 PM, Joe Orton wrote: > On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote: >> On 3/30/20 3:18 PM, jor...@apache.org wrote: >>> >>> -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes)); >>> +/* If the read above made the bucket morph, it may

Re: svn commit: r1876001 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS

2020-04-01 Thread Ruediger Pluem
On 4/1/20 2:58 PM, drugg...@apache.org wrote: > Author: druggeri > Date: Wed Apr 1 12:58:58 2020 > New Revision: 1876001 > > URL: http://svn.apache.org/viewvc?rev=1876001&view=rev > Log: > Updates for announcement of 2.4.43 > > Modified: > httpd/httpd/branches/2.4.x/CHANGES > httpd/ht

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Yann Ylavic
On Wed, Apr 1, 2020 at 2:39 PM Joe Orton wrote: > > On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote: > > On 3/30/20 3:18 PM, jor...@apache.org wrote: > > > > > > -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes)); > > > +/* If the read above made the buck

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Joe Orton
On Wed, Apr 01, 2020 at 02:04:21PM +0200, Ruediger Pluem wrote: > On 3/30/20 3:18 PM, jor...@apache.org wrote: > > > > -rv = apr_bucket_split(e, COALESCE_BYTES - (buffered + bytes)); > > +/* If the read above made the bucket morph, it may now fit > > + * entirely within th

Re: svn commit: r1875881 - /httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

2020-04-01 Thread Ruediger Pluem
On 3/30/20 3:18 PM, jor...@apache.org wrote: > Author: jorton > Date: Mon Mar 30 13:18:29 2020 > New Revision: 1875881 > > URL: http://svn.apache.org/viewvc?rev=1875881&view=rev > Log: > * modules/ssl/ssl_engine_io.c: (ssl_io_filter_coalesce): Handle the > case of a bucket which morphs to a b

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Ruediger Pluem
On 4/1/20 11:02 AM, Joe Orton wrote: > On Wed, Apr 01, 2020 at 10:06:20AM +0200, Ruediger Pluem wrote: >> >> >> On 4/1/20 9:53 AM, Joe Orton wrote: >>> On Wed, Apr 01, 2020 at 09:24:27AM +0200, Ruediger Pluem wrote: I have checked socket, pipe and cgi buckets and none of them seem to

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Joe Orton
On Wed, Apr 01, 2020 at 10:06:20AM +0200, Ruediger Pluem wrote: > > > On 4/1/20 9:53 AM, Joe Orton wrote: > > On Wed, Apr 01, 2020 at 09:24:27AM +0200, Ruediger Pluem wrote: > >> I have checked socket, pipe and cgi buckets and none of them seem to > >> return EOF. In case they hit EOF they repla

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Ruediger Pluem
On 4/1/20 9:53 AM, Joe Orton wrote: > On Wed, Apr 01, 2020 at 09:24:27AM +0200, Ruediger Pluem wrote: >> I have checked socket, pipe and cgi buckets and none of them seem to return >> EOF. In case they hit EOF they replace themselves with >> an immortal bucket of length 0. So above seems just a

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Joe Orton
On Wed, Apr 01, 2020 at 09:24:27AM +0200, Ruediger Pluem wrote: > I have checked socket, pipe and cgi buckets and none of them seem to return > EOF. In case they hit EOF they replace themselves with > an immortal bucket of length 0. So above seems just an additional safety if a > (future) morphin

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Ruediger Pluem
On 3/31/20 6:52 PM, Yann Ylavic wrote: > On Tue, Mar 31, 2020 at 7:35 AM Ruediger Pluem wrote: >> >> On 3/31/20 1:19 AM, Yann Ylavic wrote: >> >> An idea would be a to have a filter that comes after all request filters >> (either as very first connection filter or in the same >> position as t

Re: svn commit: r1874775 - /httpd/httpd/trunk/test/README.travis

2020-04-01 Thread Ruediger Pluem
On 3/31/20 6:31 PM, Yann Ylavic wrote: > On Tue, Mar 31, 2020 at 7:11 AM Ruediger Pluem wrote: >> >> On 3/31/20 1:19 AM, Yann Ylavic wrote: >>> Index: server/core_filters.c >>> === >>> --- server/core_filters.c (revision 187588