On 4/2/20 11:14 AM, Joe Orton wrote:
> On Thu, Apr 02, 2020 at 10:58:21AM +0200, Yann Ylavic wrote:
>> On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote:
>>>
+#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1)
>>>
>>> Nitpick: After having a second thought on the whole
On Thu, Apr 02, 2020 at 10:58:21AM +0200, Yann Ylavic wrote:
> On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote:
> >
> > > +#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1)
> >
> > Nitpick: After having a second thought on the whole thing, I think the
> > above name is
On Thu, Apr 02, 2020 at 10:37:01AM +0200, Ruediger Pluem wrote:
> Sounds reasonable. Thanks for explaining. Do you fix <= vs < and > vs >= or
> should I?
http://svn.apache.org/viewvc?view=revision=1876037
I hope I have tweaked this to death now, but more review definitely
welcome since I found
On Thu, Apr 2, 2020 at 6:39 AM Ruediger Pluem wrote:
>
> > +#define AP_BUCKET_IS_MORPHING(e)((e)->length == (apr_size_t)-1)
>
> Nitpick: After having a second thought on the whole thing, I think the above
> name is misleading to some extend. If MMAP is enabled
> a file bucket is also a
On 4/2/20 9:36 AM, Joe Orton wrote:
> On Thu, Apr 02, 2020 at 07:30:50AM +0200, Ruediger Pluem wrote:
>> On 4/1/20 11:44 PM, Mike Rumph wrote:
>>> I'm not very familiar with this code, so my questions might not make sense.
>>>
>>> But take a look at the following two code segments in
>>>
On Thu, Apr 02, 2020 at 07:30:50AM +0200, Ruediger Pluem wrote:
> On 4/1/20 11:44 PM, Mike Rumph wrote:
> > I'm not very familiar with this code, so my questions might not make sense.
> >
> > But take a look at the following two code segments in
> > ssl_io_filter_coalesce():
> >
> > for (e
