Re: svn commit: r1876674 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_protocol.h modules/http2/h2_request.c server/protocol.c

2020-04-17 Thread Yann Ylavic
On Fri, Apr 17, 2020 at 9:59 PM Ruediger Pluem > > On 4/17/20 6:47 PM, ylavic > > > > -if (r->status != HTTP_OK) { > > +if (!ap_check_request_header(r)) { > > access_status = r->status; > > goto die_early; > > This means we now die_early where we did not before and may not

Re: svn commit: r1876664 - in /httpd/httpd/trunk: modules/http2/h2_request.c server/protocol.c

2020-04-17 Thread Yann Ylavic
On Fri, Apr 17, 2020 at 9:43 PM Ruediger Pluem > > On 4/17/20 3:07 PM, ylavic > > > > -apr_brigade_destroy(tmp_bb); > > Why don't we destroy it any longer? tmp_bb is reused below in the die_early code, and always _cleanup() after use in ap_read_request(). If the brigade is not used anymore, th

Re: svn commit: r1876674 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_protocol.h modules/http2/h2_request.c server/protocol.c

2020-04-17 Thread Ruediger Pluem
On 4/17/20 6:47 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 17 16:47:42 2020 > New Revision: 1876674 > > URL: http://svn.apache.org/viewvc?rev=1876674&view=rev > Log: > core, h2: common ap_parse_request_line() and ap_check_request_header() code. > > Extract parsing/validation

Re: svn commit: r1876664 - in /httpd/httpd/trunk: modules/http2/h2_request.c server/protocol.c

2020-04-17 Thread Ruediger Pluem
On 4/17/20 3:07 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 17 13:07:46 2020 > New Revision: 1876664 > > URL: http://svn.apache.org/viewvc?rev=1876664&view=rev > Log: > core, h2: send EOR for early HTTP request failure. > > The core output filters depend on EOR being sent at

Re: svn commit: r1876619 - /httpd/httpd/trunk/modules/core/mod_watchdog.c

2020-04-17 Thread Yann Ylavic
On Thu, Apr 16, 2020 at 7:55 PM wrote: > > Author: jorton > Date: Thu Apr 16 17:55:48 2020 > New Revision: 1876619 > > URL: http://svn.apache.org/viewvc?rev=1876619&view=rev > Log: > * modules/core/mod_watchdog.c (wd_worker): Fix crashes snuck into > r1876599 where a destroyed pool was reused.

Re: svn commit: r1876511 - /httpd/httpd/trunk/modules/core/mod_watchdog.c

2020-04-17 Thread Joe Orton
On Wed, Apr 15, 2020 at 09:50:01AM -0400, Jim Jagielski wrote: > very, very elegant. Thank you Jim! I wonder if the new state variable is redundant with the other state variables in the watchdog structure? I don't understand the watchdog model well enough to be confident here. struct ap_watc

Re: mod_http2 crashes libhttpd.dll in 2.4.43

2020-04-17 Thread Steffen
Tested trunk r1876616. All fine now. Thanks! for fixing the regression introduced in 2.4.43 GA Made new Windows binaries of mod_http2 available at AL. Steffen On Thursday 16/04/2020 at 19:21, Stefan Eissing wrote: 🤢🙈 Fixed in and a