Re: "Forbid" directive in core?

2020-04-27 Thread Nick Kew
> On 27 Apr 2020, at 16:37, Eric Covener wrote: > > > Bumping a very old thread. tl;dr people are often surprised that when > Location sections have access control directives and overlap with the > filesystem it undoes the default > >Require all denied > We always warn against mixing

Re: "Forbid" directive in core?

2020-04-27 Thread Eric Covener
On Mon, Apr 27, 2020 at 12:14 PM Yann Ylavic wrote: > > On Mon, Apr 27, 2020 at 5:37 PM Eric Covener wrote: > > > > Bumping a very old thread. tl;dr people are often surprised that when > > Location sections have access control directives and overlap with the > > filesystem it undoes the

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Joe Orton
On Mon, Apr 27, 2020 at 04:27:56PM +0200, Yann Ylavic wrote: > On Mon, Apr 27, 2020 at 4:11 PM Joe Orton wrote: > > > > +1 from me for using the term "opaque buckets" as a synonym for > > "e->length == (apr_size_t)-1" aka "buckets with indeterminate length". > > OK thanks, just committed

Re: "Forbid" directive in core?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 5:37 PM Eric Covener wrote: > > Bumping a very old thread. tl;dr people are often surprised that when > Location sections have access control directives and overlap with the > filesystem it undoes the default > > Require all denied > Thanks for pointing at this, I

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 15:57 schrieb Joe Orton: On Sat, Apr 25, 2020 at 08:10:40PM +0200, Rainer Jung wrote: Patch available at home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Very nice! +1 from me. Does the times_per_thread logic still make any sense? It's always been wrong for

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 17:28 schrieb Yann Ylavic: On Mon, Apr 27, 2020 at 5:18 PM Rainer Jung wrote: Hi Yann, Am 27.04.2020 um 16:40 schrieb Yann Ylavic: Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: Thanks for this. Could you please create this as a PR on github as well? This

Re: "Forbid" directive in core?

2020-04-27 Thread Yehuda Katz
On Mon, Apr 27, 2020 at 11:37 AM Eric Covener wrote: > On Sat, Sep 28, 2013 at 12:21 PM Tim Bannister > wrote: > > The second time in a few days, I'm going to suggest adding an optional > parameter to a directive. > > > > Taking a leaf out of cascading stylesheets, how about “Forbidden On >

Re: "Forbid" directive in core?

2020-04-27 Thread Eric Covener
On Sat, Sep 28, 2013 at 12:21 PM Tim Bannister wrote: > > On 28 Sep 2013, at 14:19, Eric Covener wrote: > > > I've come back to this because I've struggled in another area with > > access_checker vs. access_checker_ex. I really think we need basic access > > control outside of Require and

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 5:18 PM Rainer Jung wrote: > > Hi Yann, > > Am 27.04.2020 um 16:40 schrieb Yann Ylavic: > > Hi Rainer, > > > > On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: > >>> > >>> Thanks for this. > >>> Could you please create this as a PR on github as well? This ensures that

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Hi Yann, Am 27.04.2020 um 16:40 schrieb Yann Ylavic: Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run for your patch. Thanks Rüdiger. Done and indeed

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Yann Ylavic
Hi Rainer, On Mon, Apr 27, 2020 at 3:17 PM Rainer Jung wrote: > > > > Thanks for this. > > Could you please create this as a PR on github as well? This ensures that > > all the Travis tests are run for your patch. > > Thanks Rüdiger. Done and indeed Travis found one not that I fixed but we >

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 4:11 PM Joe Orton wrote: > > +1 from me for using the term "opaque buckets" as a synonym for > "e->length == (apr_size_t)-1" aka "buckets with indeterminate length". OK thanks, just committed "something" in r1877077 because I keep messing up with my attachments today.

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Joe Orton
On Mon, Apr 27, 2020 at 03:57:37PM +0200, Yann Ylavic wrote: > On Mon, Apr 27, 2020 at 3:43 PM Yann Ylavic wrote: > > > > On Mon, Apr 27, 2020 at 2:09 PM Yann Ylavic wrote: > > > > > > https://github.com/apache/httpd/pull/117 > > > > I closed it, how about the second patch there though? > > > >

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 3:57 PM Yann Ylavic wrote: > > On Mon, Apr 27, 2020 at 3:43 PM Yann Ylavic wrote: > > > > On Mon, Apr 27, 2020 at 2:09 PM Yann Ylavic wrote: > > > > > > https://github.com/apache/httpd/pull/117 > > > > I closed it, how about the second patch there though? > > > >

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 3:43 PM Yann Ylavic wrote: > > On Mon, Apr 27, 2020 at 2:09 PM Yann Ylavic wrote: > > > > https://github.com/apache/httpd/pull/117 > > I closed it, how about the second patch there though? > >

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Joe Orton
On Sat, Apr 25, 2020 at 08:10:40PM +0200, Rainer Jung wrote: > Patch available at > > home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Very nice! +1 from me. Does the times_per_thread logic still make any sense? It's always been wrong for Linux AFAICT so maybe can just be

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 2:09 PM Yann Ylavic wrote: > > https://github.com/apache/httpd/pull/117 I closed it, how about the second patch there though? https://github.com/apache/httpd/pull/117/commits/cdf4c4a3c61340f061267cc70c456d9469e9faac

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 3:04 PM Joe Orton wrote: > > On Mon, Apr 27, 2020 at 02:29:55PM +0200, Yann Ylavic wrote: > > The call chain is: > > apr_bucket_setaside(bucket, newpool) > > => file_bucket_setaside(bucket, newpool) > > => apr_file_setaside(, bucket->data->fd, newpool) > >

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Rainer Jung
Am 27.04.2020 um 08:57 schrieb Ruediger Pluem: On 4/25/20 8:10 PM, Rainer Jung wrote: Patch available at home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Joe Orton
On Mon, Apr 27, 2020 at 02:29:55PM +0200, Yann Ylavic wrote: > The call chain is: > apr_bucket_setaside(bucket, newpool) > => file_bucket_setaside(bucket, newpool) > => apr_file_setaside(, bucket->data->fd, newpool) > => copy bucket->data->fd to newfd, move cleanup to newpool >

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Ruediger Pluem
On 4/27/20 2:29 PM, Yann Ylavic wrote: > On Mon, Apr 27, 2020 at 11:11 AM Joe Orton wrote: >> >> On Sun, Apr 26, 2020 at 05:26:02PM +0200, Yann Ylavic wrote: >>> For FILE buckets, the behaviour of apr_bucket_setaside() is to take >>> *full* ownership of the underlying apr_file, that is:

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 11:11 AM Joe Orton wrote: > > On Sun, Apr 26, 2020 at 05:26:02PM +0200, Yann Ylavic wrote: > > For FILE buckets, the behaviour of apr_bucket_setaside() is to take > > *full* ownership of the underlying apr_file, that is: allocate/move > > the file/cleanup to the new pool

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Yann Ylavic
On Mon, Apr 27, 2020 at 9:24 AM Ruediger Pluem wrote: > > On 4/26/20 5:26 PM, Yann Ylavic wrote: > > > So, how about we do that? > > Would look like the attached patch (which also removes the misleading > > Did I miss the attachment? :-) Argh :/ > Or even better, can we have this as a PR

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Joe Orton
On Sun, Apr 26, 2020 at 05:26:02PM +0200, Yann Ylavic wrote: > For FILE buckets, the behaviour of apr_bucket_setaside() is to take > *full* ownership of the underlying apr_file, that is: allocate/move > the file/cleanup to the new pool AND set the old file's fd to -1 (see > apr_file_setaside,

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Stefan Eissing
> Am 26.04.2020 um 17:26 schrieb Yann Ylavic : > > After a look at our codebase, this would work as is, all of the FILE > buckets we pass through output filters are from r->pool, so the > lifetime is within the EOR scope (I'm not totally sure about the http2 > beam case, Stefan?). Lacking a

Re: Move FILE buckets on setaside (like/as a morphing bucket)?

2020-04-27 Thread Ruediger Pluem
On 4/26/20 5:26 PM, Yann Ylavic wrote: > So, how about we do that? > Would look like the attached patch (which also removes the misleading Did I miss the attachment? :-) Or even better, can we have this as a PR against trunk on github? This ensure that it has run already through all the

Re: Providing near-time averaged monitoring data for mod_systemd and mod_status

2020-04-27 Thread Ruediger Pluem
On 4/25/20 8:10 PM, Rainer Jung wrote: > Patch available at > > home.apache.org/~rjung/patches/httpd-trunk-mon-snaps-v1_2.patch Thanks for this. Could you please create this as a PR on github as well? This ensures that all the Travis tests are run for your patch. Regards Rüdiger