Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-04-29 Thread Eric Covener
On Wed, Apr 29, 2020 at 2:43 PM Ruediger Pluem wrote: > > > > On 4/29/20 5:02 PM, Eric Covener wrote: > > On Wed, Apr 29, 2020 at 9:29 AM Joe Orton wrote: > >> > >> In uldap_connection_unbind, apr_ldap_rebind_remove() is always passed > >> NULL since ldc->ldap is either NULL on entry or is set

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-04-29 Thread Ruediger Pluem
On 4/29/20 5:02 PM, Eric Covener wrote: > On Wed, Apr 29, 2020 at 9:29 AM Joe Orton wrote: >> >> In uldap_connection_unbind, apr_ldap_rebind_remove() is always passed >> NULL since ldc->ldap is either NULL on entry or is set to NULL. This >> looks safe, but seems like an expensive noop since

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Yann Ylavic
On Wed, Apr 29, 2020 at 6:47 PM Daniel Gruno wrote: > > On 29/04/2020 10.52, Daniel Gruno wrote: > > On 29/04/2020 10.22, Daniel Gruno wrote: > >> > >>> > >>> I recommend using selfserve.apache.org > >>> to create notifications@httpd (the typical name/pattern for

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Daniel Gruno
On 29/04/2020 10.52, Daniel Gruno wrote: On 29/04/2020 10.22, Daniel Gruno wrote: I recommend using selfserve.apache.org to create notifications@httpd (the typical name/pattern for this stuff), then to use .asf.yaml to sort out the various emails. Once we

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Daniel Gruno
On 29/04/2020 10.22, Daniel Gruno wrote: I recommend using selfserve.apache.org to create notifications@httpd (the typical name/pattern for this stuff), then to use .asf.yaml to sort out the various emails. Once we are in agreement on a name here, I can get

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Daniel Gruno
On 29/04/2020 10.11, Greg Stein wrote: On Wed, Apr 29, 2020 at 8:19 AM Joe Orton > wrote: On Tue, Apr 28, 2020 at 05:19:09PM +0200, Ruediger Pluem wrote: > +1 g...@httpd.apache.org (I declare the naming discussion for the

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Greg Stein
On Wed, Apr 29, 2020 at 8:19 AM Joe Orton wrote: > On Tue, Apr 28, 2020 at 05:19:09PM +0200, Ruediger Pluem wrote: > > +1 g...@httpd.apache.org (I declare the naming discussion for the list > name opened :-)). > > This offers an easy opt-in for those who are interested in these updates. > > +1

Re: [PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-04-29 Thread Eric Covener
On Wed, Apr 29, 2020 at 9:29 AM Joe Orton wrote: > > In uldap_connection_unbind, apr_ldap_rebind_remove() is always passed > NULL since ldc->ldap is either NULL on entry or is set to NULL. This > looks safe, but seems like an expensive noop since > apr_ldap_rebind_remove() acquires a mutex and

[PATCH] mod_ldap: fix apr_ldap_rebind_remove() use

2020-04-29 Thread Joe Orton
In uldap_connection_unbind, apr_ldap_rebind_remove() is always passed NULL since ldc->ldap is either NULL on entry or is set to NULL. This looks safe, but seems like an expensive noop since apr_ldap_rebind_remove() acquires a mutex and iterates a linked list trying to find a rebind reference

Re: Can github activity (new PRs, comments) be forwarded to dev@ ?

2020-04-29 Thread Joe Orton
On Tue, Apr 28, 2020 at 05:19:09PM +0200, Ruediger Pluem wrote: > +1 g...@httpd.apache.org (I declare the naming discussion for the list name > opened :-)). > This offers an easy opt-in for those who are interested in these updates. +1 from me, does anybody know if it's actually technically