Re: svn commit: r1877345 - in /httpd/httpd/trunk/modules/ssl: ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h

2020-05-06 Thread Stefan Eissing
> Am 06.05.2020 um 10:43 schrieb Ruediger Pluem : > > > > On 5/6/20 10:27 AM, Luca Toscano wrote: >> Aside from the technical change (that IIUC it is really nice), I >> really love when the code is so well documented. Having comments in >> the code and in the commit message is great for

Re: RFC: mod_ssl features to dump for 2.5

2020-05-06 Thread Giovanni Bechis
On 5/6/20 1:01 PM, Joe Orton wrote: > On Wed, May 06, 2020 at 11:44:37AM +0100, Joe Orton wrote: >> On Mon, May 04, 2020 at 05:23:23PM +0200, Ruediger Pluem wrote: >>> On 5/4/20 3:49 PM, Joe Orton wrote: d) SSLRandomSeed. This might have made sense in 1998 but at least with OpenSSL

Re: RFC: mod_ssl features to dump for 2.5

2020-05-06 Thread Joe Orton
On Wed, May 06, 2020 at 11:44:37AM +0100, Joe Orton wrote: > On Mon, May 04, 2020 at 05:23:23PM +0200, Ruediger Pluem wrote: > > On 5/4/20 3:49 PM, Joe Orton wrote: > > > d) SSLRandomSeed. This might have made sense in 1998 but at least with > > > OpenSSL 1.1.1 which has a rewritten and

Re: RFC: mod_ssl features to dump for 2.5

2020-05-06 Thread Joe Orton
On Mon, May 04, 2020 at 05:23:23PM +0200, Ruediger Pluem wrote: > On 5/4/20 3:49 PM, Joe Orton wrote: > > d) SSLRandomSeed. This might have made sense in 1998 but at least with > > OpenSSL 1.1.1 which has a rewritten and fork-safe RAND, I think httpd > > should not be doing RAND seeding ever.

Re: svn commit: r1877345 - in /httpd/httpd/trunk/modules/ssl: ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h

2020-05-06 Thread Ruediger Pluem
On 5/6/20 10:27 AM, Luca Toscano wrote: > Aside from the technical change (that IIUC it is really nice), I > really love when the code is so well documented. Having comments in > the code and in the commit message is great for whoever is in a > similar situation like mine (namely some knowledge

Re: svn commit: r1877345 - in /httpd/httpd/trunk/modules/ssl: ssl_engine_config.c ssl_engine_init.c ssl_engine_pphrase.c ssl_private.h

2020-05-06 Thread Luca Toscano
Aside from the technical change (that IIUC it is really nice), I really love when the code is so well documented. Having comments in the code and in the commit message is great for whoever is in a similar situation like mine (namely some knowledge of httpd internals but still very far from