Re: svn commit: r1885605 - in /httpd/httpd/branches/2.4.x: ./ include/ modules/proxy/

2021-02-02 Thread Ruediger Pluem
On 1/17/21 5:21 PM, minf...@apache.org wrote: > Author: minfrin > Date: Sun Jan 17 16:21:35 2021 > New Revision: 1885605 > > URL: http://svn.apache.org/viewvc?rev=1885605&view=rev > Log: > Backport to v2.4: > > *) mod_proxy_http: handle upgrade/tunneling protocols. BZ 61616 is about >

Re: svn commit: r1885239 - in /httpd/httpd/trunk: changes-entries/proxy_wstunnel_to_http.txt docs/log-message-tags/next-number modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/mo

2021-02-02 Thread Ruediger Pluem
On 1/7/21 2:19 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Jan 7 13:19:08 2021 > New Revision: 1885239 > > URL: http://svn.apache.org/viewvc?rev=1885239&view=rev > Log: > mod_proxy_wstunnel: leave Upgrade requests handling to mod_proxy_http. > > Let mod_proxy_http's canon and sc

Re: svn commit: r1885239 - in /httpd/httpd/trunk: changes-entries/proxy_wstunnel_to_http.txt docs/log-message-tags/next-number modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/mo

2021-02-02 Thread Ruediger Pluem
On 2/2/21 11:32 AM, Ruediger Pluem wrote: > > > On 1/7/21 2:19 PM, yla...@apache.org wrote: >> Author: ylavic >> Date: Thu Jan 7 13:19:08 2021 >> New Revision: 1885239 >> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_http.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/mod

Re: svn commit: r1885573 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h modules/ssl/ssl_engine_io.c server/core.c server/core_filters.c

2021-02-02 Thread Yann Ylavic
On Mon, Feb 1, 2021 at 11:24 AM Ruediger Pluem wrote: > > + > > +should_send_brigade(bb, c, &flush); > > +if (flush) { > > +apr_int32_t nfd; > > +apr_pollfd_t pfd; > > +memset(&pfd, 0, sizeof(pfd)); > > +pfd.re

Re: svn commit: r1885239 - in /httpd/httpd/trunk: changes-entries/proxy_wstunnel_to_http.txt docs/log-message-tags/next-number modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/mo

2021-02-02 Thread Yann Ylavic
On Tue, Feb 2, 2021 at 11:32 AM Ruediger Pluem wrote: > > On 1/7/21 2:19 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Thu Jan 7 13:19:08 2021 > > New Revision: 1885239 [] > > > > -/* find the scheme */ > > -u = strchr(url, ':'); > > -if (u == NULL || u[1] != '/' || u[2] !

Re: svn commit: r1885605 - in /httpd/httpd/branches/2.4.x: ./ include/ modules/proxy/

2021-02-02 Thread Yann Ylavic
On Tue, Feb 2, 2021 at 10:32 AM Ruediger Pluem wrote: > > > New Revision: 1885605 > > > > URL: http://svn.apache.org/viewvc?rev=1885605&view=rev [] > > +/* Yield if the output filters stack is full? This is to avoid > > + * blocking and give the caller a chance to POLLOUT async. >

Re: svn commit: r1885239 - in /httpd/httpd/trunk: changes-entries/proxy_wstunnel_to_http.txt docs/log-message-tags/next-number modules/proxy/mod_proxy.h modules/proxy/mod_proxy_http.c modules/proxy/mo

2021-02-02 Thread Ruediger Pluem
On 2/2/21 3:05 PM, Yann Ylavic wrote: > On Tue, Feb 2, 2021 at 11:32 AM Ruediger Pluem wrote: >> > > Will you commit the above patch (or should I)? Done as r1886141. > Then I could propose it for backport with the other needed > core_output_filter() change. +1 > > Thanks for the review (

Re: svn commit: r1886141 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2021-02-02 Thread Yann Ylavic
On Tue, Feb 2, 2021 at 8:50 PM wrote: > > Author: rpluem > Date: Tue Feb 2 19:50:14 2021 > New Revision: 1886141 > [] > if (!scheme || u[0] != '/' || u[1] != '/' || u[2] == '\0') { > -if (!scheme && (u = strchr(url, ':')) && (u - url) > 14) { > -ap_log_rerror(APLOG_MARK,

Re: svn commit: r1885573 - in /httpd/httpd/branches/2.4.x: CHANGES STATUS docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h modules/ssl/ssl_engine_io.c server/core.c server/core_filters.c

2021-02-02 Thread Ruediger Pluem
On 2/2/21 2:58 PM, Yann Ylavic wrote: > On Mon, Feb 1, 2021 at 11:24 AM Ruediger Pluem wrote: >>> + >>> +should_send_brigade(bb, c, &flush); >>> +if (flush) { >>> +apr_int32_t nfd; >>> +apr_pollfd_t pfd; >>> +memset(&pfd, 0