piped error logs and SIGKILL

2002-10-15 Thread Brian Degenhardt
Try this in your config file: ErrorLog "|/usr/bin/tee /usr/local/apache/logs/error_log" CustomLog /bad/path/foo/bar/foo_log common This results in a silent death of apache because when it can't open the log file, it writes the error to the error log, and then immediately kill -9's the piped proc

forget quick_handler, make stuff cachable anyways

2002-07-31 Thread Brian Degenhardt
Just wanted to voice my opinion here. I do a lot of work with caching proxies and it would be really nice to have apache be intelligent to how things are cached. There's two types of changes that would really help caches and proxies, internal and external to apache: 1) Make apache modules add a

Re: quick_handler hook is completely bogus.

2002-07-30 Thread Brian Degenhardt
I'm approaching this from a caching perspective, so when a module uses quick_handler for non-caching mechanisms, my comments do not apply but here's an option: What if modules were required to set the Vary: header appropriately and have mod_cache_* honor it? This way, you're caching problem is f

Re: [PATCH] mod_rewrite and cookie setting

2002-07-17 Thread Brian Degenhardt
On Tue, Jul 16, 2002 at 12:15:41PM -0700, Adam Sussman wrote: > On Tue, Jul 16, 2002 at 10:26:49AM -0700, Ian Holsman wrote: > > Adam Sussman wrote: > > > The new cookie setting feature of mod_rewrite adds the Set-Cookie header > > > to r->headers_out. Shouldn't this be r->err_headers_out instead

questions from my trivial patch

2002-06-14 Thread Brian Degenhardt
The functions for ap_hook_open_logs, ap_hook_post_config, and ap_hook_pre_config will fail if DECLINE is returned. Is that intentional? In the quick_handler, returning HTTP_mumble will result in that status being returned in a real request, but it will fallback to the real handler in a subreques

[PATCH] mod_example.c better comments

2002-06-14 Thread Brian Degenhardt
Some of the comments were out of order or incomplete in mod_exmple.c. It was also missing ap_hook_create_request() This brings it up to date a bit. Sorry if this is kinda trivial, I'm probably going to generate a lot more silly fixes like this. Let me know if there's an optimal way/time for st