Requesting review of mod_ssl patch to enable NPN support

2012-04-13 Thread Bryan McQuade
Hi, We have a patch pending review that adds TLS NPN support to mod_ssl. https://issues.apache.org/bugzilla/show_bug.cgi?id=52210 We've received feedback from a few different reviewers and incorporated that feedback, but nobody has landed it yet. We'd appreciate it if you would be willing to

Server reloads

2010-11-12 Thread Bryan McQuade
Hi. I have read the docs but I have a few questions regarding server reloads. Under what conditions will httpd reread its conf file? Will httpd also reload its shared modules when updating conf files? I am trying to make sure that updating a conf and corresponding so on disk with a newer version

Re: Server reloads

2010-11-12 Thread Bryan McQuade
Thanks Dennis. I'm wondering what it means for modules to handle reloads correctly. What can/should a shared object do to gracefully reload? What should it not do? Are there specific hooks I should register for in order to handle reloads correctly? And if so, what should my module do in those

Re: Server reloads

2010-11-12 Thread Bryan McQuade
thanks! On Fri, Nov 12, 2010 at 10:06 AM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 12, 2010 at 9:52 AM, Bryan McQuade bmcqu...@google.com wrote: Thanks Dennis. I'm wondering what it means for modules to handle reloads correctly. What can/should a shared object do to gracefully reload

Re: Connection filters and the proxy

2010-08-23 Thread Bryan McQuade
We added the following code snippet in our connection filter. If there is a better way please let me know as I would like to switch our code to use it (I believe we require pre_connection instead of process_connection so we can't use Stefan's suggestion): // If this is not an inbound connection,

mod_deflate and vary accept-encoding

2010-08-13 Thread Bryan McQuade
Hi, In looking at the source for mod_deflate: http://www.google.com/codesearch/p?hl=en#lfs-jRjrQ3s/trunk/modules/filters/mod_deflate.cl=524 It appears to insert Vary Accept-Encoding header into every candidate response by default, which is what you would expect. But the instructions here:

Re: mod_deflate and vary accept-encoding

2010-08-13 Thread Bryan McQuade
Sorry, dumb question. Need to read before sending. :) Thank you. On Fri, Aug 13, 2010 at 3:03 PM, Eric Covener cove...@gmail.com wrote: suggest adding a line to manually add Vary Accept-Encoding to responses: # Make sure proxies don't deliver the wrong content Header append Vary User-Agent

Re: mod_deflate handling of empty initial brigade

2010-06-02 Thread Bryan McQuade
:) Great idea Brian. I can submit a patch for this if it'd be helpful. Just let me know if you'd like us to prepare a patch for this. Are there any cases where it's important for ap_pass_bridgade to pass on an empty brigade? Doesn't sound like it, but since this is a core library change I want

Re: mod_deflate handling of empty initial brigade

2010-06-01 Thread Bryan McQuade
The guide to writing output filters says: https://httpd.apache.org/docs/trunk/developer/output-filters.html#invocation An output filter should never pass an empty brigade down the filter chain. But, for good defensive programming, filters should be prepared to accept an empty brigade, and do

Re: Fast by default

2010-05-31 Thread Bryan McQuade
I had a conversation with a well known hosting provider recently and they told me they use the default Apache configuration for their shared hosting service. When I asked if they provide gzip as an option for their users, they said no, since it was not enabled by default. When I explained to them

Re: Working on mod_spdy, looking for contributions and feedback

2010-02-12 Thread Bryan McQuade
On Thu, Feb 11, 2010 at 7:38 PM, Graham Leggett minf...@sharp.fm wrote: On 11 Feb 2010, at 8:52 PM, Bryan McQuade wrote: We've written up a document describing our current ideas for multiplexing here: http://code.google.com/p/mod-spdy/wiki/MultiplexIdeas but we could really use feedback from

Re: Working on mod_spdy, looking for contributions and feedback

2010-02-12 Thread Bryan McQuade
standards at that point. On Fri, Feb 12, 2010 at 3:52 AM, jean-frederic clere jfcl...@gmail.com wrote: On 02/11/2010 07:52 PM, Bryan McQuade wrote: A small group of us have been working on mod_spdy, an open source filter module that provides support for the SPDY protocol in Apache. I note that C

Working on mod_spdy, looking for contributions and feedback

2010-02-11 Thread Bryan McQuade
A small group of us have been working on mod_spdy, an open source filter module that provides support for the SPDY protocol in Apache. SPDY is an experimental protocol described here http://dev.chromium.org/spdy/spdy-whitepaper. It's currently supported in the Chromium browser (Google Chrome) and