Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Eric Norris via dev
On Wed, Dec 20, 2023 at 10:58 AM Joe Orton wrote: > > On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote: > > On 12/20/23 4:08 PM, Yann Ylavic wrote: > > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote: > > >> https://github.com/apache/httpd/pull/400 > > > > > > Thanks, looks good

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Eric Norris via dev
On Wed, Dec 20, 2023 at 10:43 AM Joe Orton wrote: > > In the repro case you posted, only one brigade is passed by the handler, > with that I saw the "delayed last chunk" behaviour but not the Zlib > double-deinit error log. I think the Zlib error would only be triggered > by passing a second

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Eric Norris via dev
On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote: > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote: > > > > I was surprised this made a difference to the behaviour on the wire. It > > seems like the chunk filter has suboptimal behaviour here. If you take > > an output brigade like either: >

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Eric Norris via dev
47:44AM -0400, Eric Norris via dev wrote: > > Hello again, > > > > I'd like to politely bump this message to see if anyone would mind > > taking a look at this patch, either here or on GitHub. > > Apologies, I got quite distracted by the "rapid reset" security s

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-10-30 Thread Eric Norris via dev
Hello again, I'd like to politely bump this message to see if anyone would mind taking a look at this patch, either here or on GitHub. Eric Norris Etsy On Mon, Oct 9, 2023 at 2:50 PM Eric Norris wrote: > > Hello all, > > I've submitted a pull request on GitHub here: >

[PATCH] mod_deflate: remove filter after seeing EOS

2023-10-09 Thread Eric Norris via dev
Hello all, I've submitted a pull request on GitHub here: https://github.com/apache/httpd/pull/387, per the instructions I found at https://httpd.apache.org/contribute. I figured it may also be useful to share the patch here, but please feel free to redirect me as this is my first time