Re: mod_ssl NPN API rejig (was Re: Intent to revert commit r1332643)

2013-05-29 Thread Matthew Steele
On Wed, May 29, 2013 at 12:06 PM, Joe Orton wrote: > On Wed, May 29, 2013 at 11:37:14AM -0400, Matthew Steele wrote: > > Oops, yes, RUN_ALL semantics are desired; the misleading API description > is > > my fault, sorry. (I confess I never really understood why RUN_ALL hooks

Re: mod_ssl NPN API rejig (was Re: Intent to revert commit r1332643)

2013-05-29 Thread Matthew Steele
On Wed, May 29, 2013 at 11:14 AM, Joe Orton wrote: > On Wed, May 29, 2013 at 10:52:10AM -0400, Matthew Steele wrote: > > - In modssl_register_npn, it appears that the code creates > > new npn_advertfns and npn_negofns arrays on every call, even if they > > already exist

Re: mod_ssl NPN API rejig (was Re: Intent to revert commit r1332643)

2013-05-29 Thread Matthew Steele
Hi Joe, Two questions about this change: - In modssl_register_npn, it appears that the code creates new npn_advertfns and npn_negofns arrays on every call, even if they already exist. This would seem to prevent multiple modules from registering callbacks. Presumably this is not intended? Am I

Re: mod_deflate handling of empty initial brigade

2010-06-01 Thread Matthew Steele
I went ahead and created a bug entry/patch to make the (trivial) change to mod_deflate to make it conform to the "Guide to writing output filters": https://issues.apache.org/bugzilla/show_bug.cgi?id=49369 Brian, does this patch to mod_deflate fix your problem? Nick, does this change seem reaso

Re: mod_deflate handling of empty initial brigade

2010-06-01 Thread Matthew Steele
On Tue, Jun 1, 2010 at 11:02 AM, "Plüm, Rüdiger, VF-Group" wrote: >> The guide to writing output filters says: >> >> https://httpd.apache.org/docs/trunk/developer/output-filters.h >> tml#invocation >> >> "An output filter should never pass an empty brigade down the filter >> chain. But, for good d