RE: [PATCH] Review Test: mod_include redesign

2003-08-18 Thread Ron Park
until the mod_include patch is considered ready for release (production) in the 2.0 branch before I would consider upgrading and doing a production test. Regards, Glenn André Malo wrote: [CC to Ron Park and Glenn Nielsen to get this onto their radar] Since it turned out that one

mod_include: YABU (yet another bug uncovered)

2003-08-14 Thread Ron Park
Hi Again, Well, we've come across another mod_include/cross brigade bug for which we currently don't yet have a patch (should have one soon but thought I'd give others a crack at it). :D Here are two simple snippets, one which works, one which causes a core dump even with the latest patch of

RE: mod_include: YABU (yet another bug uncovered)

2003-08-14 Thread Ron Park
- From: Ron Park [mailto:[EMAIL PROTECTED] Sent: Thursday, August 07, 2003 4:09 PM To: '[EMAIL PROTECTED]' Subject: mod_include: YABU (yet another bug uncovered) Hi Again, Well, we've come across another mod_include/cross brigade bug for which we currently don't yet have a patch (should

RE: Two mod_include problems

2003-07-21 Thread Ron Park
Sorry for not following up on this thread; other work priorities set me off on a different tangent. Unfortunately, it seems your patch from 07/12/03 does not work on our pages. :( We haven't yet tracked down *how* it's not working though. More info to follow. Ron -Original Message-

RE: Two mod_include problems

2003-07-21 Thread Ron Park
Yes, this is the patch we tried. -Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2003 1:25 PM To: [EMAIL PROTECTED]; Ron Park Subject: RE: Two mod_include problems On Mon, 21 Jul 2003, Ron Park wrote: Unfortunately, it seems your

RE: Two mod_include problems

2003-07-21 Thread Ron Park
: Before If AnythingSomethingElseAfter if (when $FALSE is not defined) With the patch, it seems to throw away too much! SomethingElseAfter if :( Ron -Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2003 2:31 PM To: Ron Park Cc: '[EMAIL

RE: Two mod_include problems

2003-07-21 Thread Ron Park
Does the test case have the following turned on? AddOutputFilter BUCKETEER;INCLUDES .shtml Ron -Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] Sent: Monday, July 21, 2003 4:55 PM To: [EMAIL PROTECTED] Cc: Ron Park Subject: RE: Two mod_include problems On Mon

RE: Two mod_include problems

2003-07-21 Thread Ron Park
21, 2003 5:26 PM To: [EMAIL PROTECTED] Cc: Ron Park Subject: RE: Two mod_include problems It actually had: SetOutputFilter BUCKETEER But I changed it to: AddOutputFilter BUCKETEER;INCLUDES .shtml And it still passes. --Cliff

RE: Two mod_include problems

2003-07-10 Thread Ron Park
: Wednesday, July 09, 2003 6:54 PM To: [EMAIL PROTECTED] Subject: Re: Two mod_include problems * Ron Park wrote: At line 438 of mod_include, we see the code is set up to handle this 'left over partial match' and it increments the temporary buffer pointer, c, by 2 as it walks past

RE: Two mod_include problems

2003-07-10 Thread Ron Park
We'll give this patch a shot. Ron -Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 09, 2003 10:27 PM To: Ron Park Cc: [EMAIL PROTECTED] Subject: Re: Two mod_include problems yOn Wed, 9 Jul 2003, Ron Park wrote: This problem revolves

RE: Two mod_include problems

2003-07-10 Thread Ron Park
We tried using mod_bucketeer to recreate our problems but all attempts failed. :( Ron -Original Message- From: Cliff Woolley [mailto:[EMAIL PROTECTED] Sent: Thursday, July 10, 2003 4:45 PM To: '[EMAIL PROTECTED]' Subject: RE: Two mod_include problems On Thu, 10 Jul 2003, Ron

RE: Two mod_include problems

2003-07-09 Thread Ron Park
later. It seemed very redundant. If anyone knows why this was done and it is important, I can provide a patch for the two bugs without this change. Thanks, Ron -Original Message- From: Ron Park [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 09, 2003 3:50 PM To: '[EMAIL PROTECTED