r->useragent_addr is assigned on ap_read_request (http_core.c),
called from ap_process_http_(async_)connection
called from process_connection hook (APR_HOOK_REALLY_LAST).
The SEGV occured on process_connection hook, maybe before
ap_process_http_(async_)connection,
#11 0x7fd44f91fd4f in
SSLv3 is now insecure (CVE-2014-3566, POODLE)
Let's disable SSLv3 by default, at least trunk.
SSLProtocol default is all.
http://httpd.apache.org/docs/trunk/mod/mod_ssl.html#sslprotocol
all means a shortcut for ``+SSLv3 +TLSv1'' or - when using OpenSSL
1.0.1 and later - ``+SSLv3 +TLSv1 +TLSv1.1
fixed in r161877.
-rv = errno;
rv still needs to get set to something non-zero as part of reporting failure
to the caller; EPERM perhaps, or APR_EGENERAL?
You are right.
I think EPERM is better. At least chroot(2) and chown（２） returns it.
--- httpd/httpd/trunk/include/ap_regex.h (original)
+++ httpd/httpd/trunk/include/ap_regex.h Wed Jul 23 20:27:32 2014
@@ -79,6 +79,12 @@ extern C {
#define AP_REG_MATCH MATCH_ /** suggested prefix for ap_regname */
+/* Arguments for ap_pcre_version_string */
+enum {
+
--- httpd/httpd/trunk/configure.in (original)
+++ httpd/httpd/trunk/configure.in Wed Jul 23 19:01:45 2014
@@ -236,7 +236,9 @@ if test $PCRE_CONFIG != false; then
fi
case `$PCRE_CONFIG --version` in
[[1-5].*])
-AC_MSG_ERROR([Need at least pcre version 6.0])
+
Hello
I found there are ABI compatibility checker tools.
I tried a below tool, and works fine for me.
http://ispras.linuxbase.org/index.php/ABI_compliance_checker
In the past, we made unintentional ABI breakages in the release
branch. (2.2.18, 2.2.25...)
Systematic check will help us avoiding
2014-06-26 12:34 GMT+09:00 Eric Covener cove...@gmail.com:
[cut]
I think this is only a performance concern.
I think many things and yes, I realize maybe performance can be
worse than before in both socket readable case.
Before:
poll (event MPM)
pollset_remove
poll (proxy_wstunnel)
read/write
Reverted as r1605946
2014-06-25 21:33 GMT+09:00 Eric Covener cove...@gmail.com:
On Wed, Jun 25, 2014 at 8:24 AM, taka...@apache.org wrote:
Refactor asynchronous mod_proxy_wstunnel using pollfd returned by MPM.
r1601943 and r1605307 made Event MPM return woken pollfd, so async
wstunnel doesn't need its own
If both sockets are readable, we'll go all the way through
ap_mpm_register_socket_callback_timeout + locking queues and getting
dispatched to a new thread to read the 2nd socket.
So, you think the new code is poor performance than before?
Or are you afraid that the 1st and 2nd socket are
I tried trunk mod_proxy_wstunnel with ProxyWebsocketAsync On, and it
doesn't work.
ProxyWebsocketAsync is experimental or under development ?
2014-06-13 20:27 GMT+09:00 Eric Covener cove...@gmail.com:
On Fri, Jun 13, 2014 at 4:42 AM, Takashi Sato taka...@tks.st wrote:
I tried trunk mod_proxy_wstunnel with ProxyWebsocketAsync On, and it
doesn't work.
ProxyWebsocketAsync is experimental or under development ?
It might be good
+1
How about automated test?
http://svn.apache.org/repos/asf/httpd/test/
And I want CI for doc build (at least validate-xml).
-baton-cancel_event-canceled = 1;
+if(baton-cancel_event){
Hi there,
You need to add a space between if and ( and between ) and { ;)
Thanks!
I forgot the coding style rule.
Fixed in r1602544. thanks.
2014-06-12 3:26 GMT+09:00 Mike Rumph mike.ru...@oracle.com:
On 6/11/2014 9:39 AM, taka...@apache.org wrote:
--- httpd/httpd/trunk/include/ap_mpm.h (original)
+++ httpd/httpd/trunk/include/ap_mpm.h Wed Jun 11 16:39:34 2014
@@ -198,6 +198,7 @@ AP_DECLARE(apr_status_t) ap_mpm_query(in
/** @}
r1601291 causes SEGV.
# Failed test 2 in t/ssl/proxy.t at line 56
# Failed test 115 in t/ssl/proxy.t at line 56 fail #3
[ error] oh gosh, server dumped core
[ error] for stacktrace, run: gdb /home/st/c99fix/apache/bin/httpd
-core /home/st/c99fix/httpd-test/t/core.3649
[ error] oh nuts, server
On Mon, 2 Jan 2012 23:06:35 +0100
Stefan Fritsch s...@sfritsch.de wrote:
On Monday 02 January 2012, Takashi Sato wrote:
mod_heartbeat
mod_heartmonitor
mod_lbmethod_heartbeat
These have no documentation.
Is that OK we release GA with no docs modules?
I am +0.5 for removing them
mod_heartbeat
mod_heartmonitor
mod_lbmethod_heartbeat
These have no documentation.
Is that OK we release GA with no docs modules?
--
佐藤 高志 (Takashi Sato)
taka...@lans-tv.com
On Sat, 21 Nov 2009 09:44:54 +0100
Ruediger Pluem rpl...@apache.org wrote:
On 11/21/2009 02:43 AM, Takashi Sato wrote:
Current KeepAlive dirctive accept anything but Off or 0
as On for compatibility,
The change from 0/1 to Off/On was done in 1.3 or before.
I'd like to change
Current KeepAlive dirctive accept anything but Off or 0
as On for compatibility,
The change from 0/1 to Off/On was done in 1.3 or before.
I'd like to change KeepAlive to AP_INIT_FLAG.
so that KeepAlive accepts only On or Off.
comments ?
Why are these in mod_proxy?
I'd like to move AllowCONNECT to mod_proxy_connect
and ProxyFtpCharset to mod_proxy_ftp.
mod_info's new feature doesn't compile against apr/apr-util 1.3.x
/usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function
'show_server_settings':
/usr/home/test/httpd-trunk/modules/generators/mod_info.c:363: warning: implicit
declaration of function 'apu_version_string'
Sorry. I accidentally committed mod_info.c of 2.2.x branches.
Should I revert it? Or what should I do?
On Thu, 09 Jul 2009 13:45:35 -
taka...@apache.org wrote:
Author: takashi
Date: Thu Jul 9 13:45:35 2009
New Revision: 792554
URL: http://svn.apache.org/viewvc?rev=792554view=rev
On Thu, 09 Jul 2009 09:06:52 -0500
William A. Rowe, Jr. wr...@rowe-clan.net wrote:
Takashi Sato wrote:
mod_info's new feature doesn't compile against apr/apr-util 1.3.x
/usr/home/test/httpd-trunk/modules/generators/mod_info.c: In function
'show_server_settings':
/usr/home/test/httpd
On Thu, 9 Jul 2009 16:17:15 +0200
Plüm, Rüdiger, VF-Group ruediger.pl...@vodafone.com wrote:
-Original Message-
From: Takashi Sato [mailto:taka...@lans-tv.com]
Sent: Donnerstag, 9. Juli 2009 16:10
To: dev@httpd.apache.org
Subject: Apology for r792554
Sorry. I
The third argument of ap_register_provider and ap_lookup_provider is
provider_version.
Most modules use hardcoded 0 as provider_version, but is it correct way?
I think mod_socache_* approach is right.
* include/ap_socache.h line 167:
/** The provider group used to register socache providers.
On Fri, 12 Dec 2008 20:31:31 -0600
William A. Rowe, Jr. wr...@rowe-clan.net wrote:
Takashi Sato wrote:
Event MPM has been Experimental for a long time.
Is there any plan to mark as Productional MPM?
Or any plan to drop it like Leader, Threadpool or Perchild?
Right now the push
On Fri, 12 Dec 2008 12:27:11 -0800
Paul Querna c...@force-elite.com wrote:
Anything else anyone thinks would be good to get in?
How about increasing worker_score::request?
This was originally proposed in Oct 2007.
Event MPM has been Experimental for a long time.
Is there any plan to mark as Productional MPM?
Or any plan to drop it like Leader, Threadpool or Perchild?
Regards,
Takashi
-active = 1;
+
+rv = apr_parse_addr_port(host_str, scope_id, port, mcast_addr, p);
cmd-temp_pool is better than p.
Regards,
Takashi
--
Takashi Sato [EMAIL PROTECTED]
terminate_header insert a useless header X-Pad: avoid browser bug
to avoid a bug in Netscape Navigator 2.x - 4.0b2.
This workaround was introduced in 1997, r77941, Apache 1.2b9.
In 2008, this workaround is no more needed.
Let's remove it from trunk!
Regards,
Takashi
Index:
In trunk these files are missing svn:eol-style native
docs\manual\mod\mod_buffer.html
docs\manual\mod\mod_buffer.html.en
docs\manual\mod\mod_buffer.xml
docs\manual\mod\mod_buffer.xml.meta
docs\manual\mod\mod_privileges.html
docs\manual\mod\mod_privileges.html.en
docs\manual\mod\mod_privileges.xml
http://httpd.apache.org/docs/trunk/mod/mod_authz_core.html#matchall
If none of the directives contained within the MatchAll directive fails,
and at least one succeeds, then the MatchAll directive succeeds.
According to this, following config would grant an access from 127.0.0.1
with no
find_default_item passes an imperfect request_rec to find_item.
find_item calls ap_field_noparam with uninitialized memory pool (r-pool).
Though this doesn't matter since ap_field_noparam simply returns NULL when
the 2nd argument is NULL, IMHO this should be fixed.
The attached patch makes
I built trunk with --with-mpm=simple, and I have found :
* simple_io.c line 111 and 145 cause a build falure with
--enable-maintainer-mode .
* simple_children.c should include simple_children.h.
* simple_io_timeot_cb should be static.
On Tue, 28 Oct 2008 16:16:38 -0700
Paul Querna [EMAIL PROTECTED] wrote:
Paul Querna wrote:
André Malo wrote:
* Paul Querna wrote:
Ruediger Pluem wrote:
This does not work on ANSI C compilers. Declarations need to be at the
start of the block.
Then lets not support them.
C90
Sorry for pointing out this after backported.
On Tue, 27 May 2008 16:11:40 -
[EMAIL PROTECTED] wrote:
@@ -80,6 +80,10 @@
** Switched to the new abstract pollset API, allowing ab to
** take advantage of future apr_pollset_t scalability improvements.
** Contributed
CHANGES of 2.2 don't say r583152.
This is not a major change from technical side,
but mod_status shows many OPTIONS * and
some users are frightened.
http://svn.apache.org/viewvc?view=revrevision=583152
Merge r517233 from trunk:
* server/mpm_common.c (dummy_connection): Use OPTIONS * for
PR44631 with-included-apr fails to work when using a separate buildroot
https://issues.apache.org/bugzilla/show_bug.cgi?id=44631
Isn't it?
On Wed, 09 Apr 2008 11:46:48 -
[EMAIL PROTECTED] wrote:
Added: httpd/httpd/trunk/docs/manual/mod/mod_auth_form.xml
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_auth_form.xml?rev=646285view=auto
On Tue, 08 Apr 2008 14:38:17 +0200
Graham Leggett [EMAIL PROTECTED] wrote:
[EMAIL PROTECTED] wrote:
URL: http://svn.apache.org/viewvc?rev=645877view=rev
Log:
No var declarations in the middle of the code.
This looked suspiciously like a change of line endings happened somehow?
This is the list of files where svn:eol-style property is missing.
modules/proxy/mod_proxy_fcgi.dsp: CRLF
the others: none
docs/manual/bind.html.tr.utf8
docs/manual/bind.xml.tr
docs/manual/glossary.html.tr.utf8
docs/manual/glossary.xml.tr
docs/manual/install.html.tr.utf8
On Mon, 07 Apr 2008 10:00:34 -
[EMAIL PROTECTED] wrote:
Author: pquerna
Date: Mon Apr 7 03:00:32 2008
New Revision: 645437
URL: http://svn.apache.org/viewvc?rev=645437view=rev
Log:
Remove ap_graceful_stop_signalled from all MPMs.
(snip)
Modified: httpd/httpd/trunk/include/ap_mpm.h
On Fri, 07 Mar 2008 12:13:14 +0100
Matthieu Estrade [EMAIL PROTECTED] wrote:
I actually need this directive to work better with some stream data. Can
somebody confirm the modification must be done in the code and not in
the documentation ?
ProxyIOBufferSize was added on Mar 9, 2002
On Fri, 07 Mar 2008 14:00:41 +0100
Matthieu Estrade [EMAIL PROTECTED] wrote:
but 20 or 40 or more is possible
when you have very little data length sent on a stream on http (like
real time app trading app using http).
I agree. I missed the point.
mod_rewrite.h and mod_so.h is also missing,
and there might be other missings.
only change history was modified.
MODULE_MAGIC_NUMBER_MINOR was forgotton.
On Fri, 11 Jan 2008 18:53:51 -
[EMAIL PROTECTED] wrote:
Author: covener
Date: Fri Jan 11 10:53:48 2008
New Revision: 611259
URL: http://svn.apache.org/viewvc?rev=611259view=rev
Log:
minor MMN bump for r611199
requires a minor bump?
On Fri, 11 Jan 2008 15:07:57 -
[EMAIL PROTECTED] wrote:
Author: covener
Date: Fri Jan 11 07:07:53 2008
New Revision: 611199
URL: http://svn.apache.org/viewvc?rev=611199view=rev
Log:
*) mod_logio: Provide optional function to allow modules to adjust the
On Thu, 10 Jan 2008 09:06:49 -0500
Jim Jagielski [EMAIL PROTECTED] wrote:
On Jan 9, 2008, at 4:42 PM, Jim Jagielski wrote:
Just a FYI: Since I have some plans for this evening, the
TR of the Holy Trinity :) will occur tomorrow am.
Will give it a few more hours and then will TR
Type of HTTP error code is int, isn't it?
r609549:
+static apr_status_t bail_out_on_error(http_ctx_t *ctx,
+ ap_filter_t *f,
+ apr_status_t http_error)
+{
r609550:
+apr_status_t http_error =
On Fri, 4 Jan 2008 15:00:46 -0500
Jim Jagielski [EMAIL PROTECTED] wrote:
Apache HTTP Server fans,
The latest versions of all 3 variants of Apache HTTP Server (1.3.40,
2.0.62 and 2.2.7) have been tagged.
These are not updated in 2.2:
manual/mod/quickreference.html.ko.euc-kr
I'm not good at English. If you can't catch what I say, please see the attached
patch.
This doesn't have to meet 0.9.1, but may affect performance.
modules/ftp/ftp_message.c line 53:
strncpy(outptr, time_str, outlen);
if (outlen APR_CTIME_LEN - 1) {
Hello.
I just compiled mod_ftp trunk with httpd 2.2.7-dev on Fedora 8.
gcc 4.1.2 with -Wmissing-declarations says:
mod_ftp.c:831: warning: no previous prototype for 'ftp_epsv_ignore_family'
No headers declare ftp_epsv_ignore_family, it is without AP_DECLARE and no
sources except mod_ftp.c call
in mod_example_ipc.c
How about AP_NEED_SET_MUTEX_PERMS istead of MOD_EXIPC_SET_MUTEX_PERMS ?
On Sun, 18 Nov 2007 15:41:04 -
[EMAIL PROTECTED] wrote:
Author: sctemme
Date: Sun Nov 18 07:41:03 2007
New Revision: 596093
URL: http://svn.apache.org/viewvc?rev=596093view=rev
Log:
* Move
be incremented.
--
Takashi Sato
[EMAIL PROTECTED]
--
Takashi Sato
[EMAIL PROTECTED]
if (APR_STATUS_IS_TIMEUP(status) || APR_STATUS_IS_EAGAIN(status)) {
return 1;
}
return 0;
--
Takashi Sato
[EMAIL PROTECTED]
before the patch:
[Sat Sep 29 01:08:41 2007] [notice] Apache/2.2.4 (Win32) configured -- resuming
normal operations
[Sat Sep 29 01:08:41 2007
-handler, mymodule) != 0) return DECLINED;
to the first line of handler function of your module.
--
Takashi Sato
[EMAIL PROTECTED]
59 matches
Mail list logo
