Re: [PATCH] Close connections in mod_auth_ldap #2

2002-07-22 Thread Graham Leggett
Scott Lamb wrote: > Okay, now I understand what you are saying. Here's a patch that should > do that. It seems to solve my problem and is definitely cleaner than my > last patch. I have just committed your patch, but I cannot test it as the LDAP compile seems broken at the moment. Regards, Gra

Re: [PATCH] Close connections in mod_auth_ldap

2002-07-18 Thread Graham Leggett
Scott Lamb wrote: > util_ldap_connection_close() is a misnomer, I think. It just releases a > lock. ("I'm done with this LDAP connection," rather than "unbind this > LDAP connection.") Since mod_auth_ldap_auth_checker only deals with one > of these at a time, a (sub)pool is inappropriate, corr

Re: [PATCH] Close connections in mod_auth_ldap

2002-07-18 Thread Scott Lamb
Justin Erenkrantz wrote: > On Thu, Jul 18, 2002 at 03:49:11PM -0500, Scott Lamb wrote: > >>mod_auth_ldap is never releasing locks in mod_auth_ldap_auth_checker, so >>OpenLDAP eventually runs out of filehandles. pam_ldap and nss_ldap stop >>working, badness happens. > > > Quick thought - should

Re: [PATCH] Close connections in mod_auth_ldap

2002-07-18 Thread Justin Erenkrantz
On Thu, Jul 18, 2002 at 03:49:11PM -0500, Scott Lamb wrote: > mod_auth_ldap is never releasing locks in mod_auth_ldap_auth_checker, so > OpenLDAP eventually runs out of filehandles. pam_ldap and nss_ldap stop > working, badness happens. Quick thought - should the closing of the connections be reg

[PATCH] Close connections in mod_auth_ldap

2002-07-18 Thread Scott Lamb
mod_auth_ldap is never releasing locks in mod_auth_ldap_auth_checker, so OpenLDAP eventually runs out of filehandles. pam_ldap and nss_ldap stop working, badness happens. -- Scott Lamb Call util_ldap_connection_close in every exit path from mod_auth_ldap_auth_checker. Index: modules/httpd-lda