Re: [PATCH] IPLookups (revisited)

2003-03-11 Thread Chris Monson
what does "change the entries in proxy_util.c" mean? There are some calls to apr_sockaddr_info_get in proxy_util.c, and I wasn't really sure whether they should be looking at this flag or not. In some cases (where we already have an IP address, etc) it is clearly something that they should

Re: [PATCH] IPLookups (revisited)

2003-03-11 Thread Bill Stoddard
Jeff Trawick wrote: Chris Monson wrote: I still want to know whether it makes sense to change the entries in proxy_util.c, what does "change the entries in proxy_util.c" mean? and that requires a little discussion as to whether a request_rec pointer should be required in the ap_get_iplookup_fl

Re: [PATCH] IPLookups (revisited)

2003-03-11 Thread Bill Stoddard
Bill Stoddard wrote: This function is definitely useful but I'm not too keen on the directive name (but maybe its okay). Maybe something like: EnableIP all|ipv4|ipv6 I'm also wondering if there are any needs/opportunities to control other ipv4 vs ipv6 behaviour of the server? Bill Jeff and I

Re: [PATCH] IPLookups (revisited)

2003-03-11 Thread Jeff Trawick
Chris Monson wrote: I still want to know whether it makes sense to change the entries in proxy_util.c, what does "change the entries in proxy_util.c" mean? and that requires a little discussion as to whether a request_rec pointer should be required in the ap_get_iplookup_flags function or not.

Re: [PATCH] IPLookups (revisited)

2003-03-10 Thread Bill Stoddard
This function is definitely useful but I'm not too keen on the directive name (but maybe its okay). Maybe something like: EnableIP all|ipv4|ipv6 I'm also wondering if there are any needs/opportunities to control other ipv4 vs ipv6 behaviour of the server? Bill

Re: [PATCH] IPLookups (revisited)

2003-03-07 Thread Jeff Trawick
I'll get off my ass and pore over it soon. Chris Monson wrote: So, any votes? Any thoughts? Chris Monson wrote: [PATCH]

Re: [PATCH] IPLookups (revisited)

2003-03-07 Thread Chris Monson
So, any votes? Any thoughts? Chris Monson wrote: [PATCH]

[PATCH] IPLookups (revisited)

2003-03-04 Thread Chris Monson
Jeff Trawick wrote: Chris Monson wrote: (patch) A couple of comments: Why not just store whatever flags should be passed in to apr_sockaddr_info_get() I have changed it to store the flag itself, rather than an enumeration of possible settings. In the code below, we already have an IPv4 addre