[PATCH] PR 17629 and all that

2010-06-08 Thread Joe Orton
https://issues.apache.org/bugzilla/show_bug.cgi?id=17629 Here's an attempt at fixing the dreaded PR 17629. This is a bug in the handling of the output filter chain at the point where an internal redirect is applied to a subrequest. Complications: a) a subrequest's filter chain may start at

Re: [PATCH] PR 17629 and all that

2010-06-08 Thread Dennis J.
On 06/08/2010 02:37 PM, Joe Orton wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=17629 Here's an attempt at fixing the dreaded PR 17629. This is a bug in the handling of the output filter chain at the point where an internal redirect is applied to a subrequest. Complications: a) a

RE: [PATCH] PR 17629 and all that

2010-06-08 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Joe Orton Sent: Dienstag, 8. Juni 2010 14:38 To: dev@httpd.apache.org Subject: [PATCH] PR 17629 and all that https://issues.apache.org/bugzilla/show_bug.cgi?id=17629 Here's an attempt at fixing the dreaded PR 17629. This is a bug in the handling

Re: [PATCH] PR 17629 and all that

2010-06-08 Thread Joe Orton
On Tue, Jun 08, 2010 at 05:20:16PM +0200, Plüm, Rüdiger, VF-Group wrote: Is it possible to have any non subrequest specific filters below the ap_subreq_core_filter_handle? It is no that the current patch does not handle this but wouldn't it be possible to just throw away any filter between

RE: [PATCH] PR 17629 and all that

2010-06-08 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Joe Orton Sent: Dienstag, 8. Juni 2010 17:36 To: dev@httpd.apache.org Subject: Re: [PATCH] PR 17629 and all that On Tue, Jun 08, 2010 at 05:20:16PM +0200, Plüm, Rüdiger, VF-Group wrote: Is it possible to have any non subrequest specific filters

Re: [PATCH] PR 17629 and all that

2010-06-08 Thread Joe Orton
On Tue, Jun 08, 2010 at 06:17:29PM +0200, Plüm, Rüdiger, VF-Group wrote: I'd spent some time working on exactly that approach, trying to answer that question. But surprisingly the answer is yes - the subreq filter has ftype=AP_FTYPE_CONTENT_SET, so any filter registered with an ftype

Re: [PATCH] PR 17629 and all that

2010-06-08 Thread Joe Orton
So since nobody has told me I'm an idiot yet, I've committed this to the trunk for wider testing: http://svn.apache.org/viewvc?view=revisionrevision=952828 Regards, Joe