RE: [PATCH] RE: Regarding parse_byterange()

2004-05-12 Thread Mathihalli, Madhusudan
>-Original Message- >From: Joe Orton [mailto:[EMAIL PROTECTED] >Sent: Friday, April 30, 2004 3:08 AM > >Looks fine, though it doesn't handle errors in apr_atoi64 >itself so it would be good to surround the calls with a single >errno = 0 / ... / >if (errno) return -1; check too. > It s

Re: [PATCH] RE: Regarding parse_byterange()

2004-04-30 Thread Joe Orton
On Thu, Apr 29, 2004 at 09:43:34AM -0700, Mathihalli, Madhusudan wrote: > >-Original Message- > >From: Joe Orton [mailto:[EMAIL PROTECTED] > [SNIP] > > > >> What if the user really sent a > >> large value for a small file ? Instead of erroring out - > >thanks to the > >> overflow mechanism

[PATCH] RE: Regarding parse_byterange()

2004-04-29 Thread Mathihalli, Madhusudan
>-Original Message- >From: Joe Orton [mailto:[EMAIL PROTECTED] [SNIP] > >> What if the user really sent a >> large value for a small file ? Instead of erroring out - >thanks to the >> overflow mechanism, we'll probably end up serving a sane result - >> Should we leave it that way ? > >Oh,