Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-29 Thread Jim Jagielski
On Oct 24, 2007, at 9:37 PM, Jeff Trawick wrote: I vote for the small patch, and canl also throw in a spell check for that last comment above. Both look good and pass tests, but I also prefer, and vote +1 for, the small patch :)

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-26 Thread Jim Jagielski
Should have review cycles over the weekend... On Oct 24, 2007, at 9:37 PM, Jeff Trawick wrote: On 10/22/07, Jeff Trawick <[EMAIL PROTECTED]> wrote: like 2.0/2.2/trunk attached is an updated patch for the boil-the-ocean flavor; at the bottom is a tiny alternative some ways to slice through t

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-26 Thread Eric Covener
On 10/24/07, Jeff Trawick <[EMAIL PROTECTED]> wrote: > I vote for the small patch, and canl also throw in a spell check for > that last comment above. Couldn't find any problem in either the big or small patches, which I guess amounts to a vote for the small patch (although axing the body of that

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-24 Thread Jeff Trawick
On 10/22/07, Jeff Trawick <[EMAIL PROTECTED]> wrote: > like 2.0/2.2/trunk attached is an updated patch for the boil-the-ocean flavor; at the bottom is a tiny alternative some ways to slice through the big patch: 1. my BIG 1.3 patch vs. the 2.0 commit essentially same changes except for s/apr_d

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-23 Thread Jim Jagielski
On Oct 23, 2007, at 10:21 AM, Jeff Trawick wrote: On 10/23/07, Jim Jagielski <[EMAIL PROTECTED]> wrote: On Oct 22, 2007, at 7:20 PM, Jeff Trawick wrote: like 2.0/2.2/trunk I'm looking for a conceptual +1 out there. You got it. Conceptual +1 :) Thanks ;) Kind of silly I realize, but I

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-23 Thread Jeff Trawick
On 10/23/07, Jim Jagielski <[EMAIL PROTECTED]> wrote: > > On Oct 22, 2007, at 7:20 PM, Jeff Trawick wrote: > > > like 2.0/2.2/trunk > > > > I'm looking for a conceptual +1 out there. > > > > You got it. Conceptual +1 :) Thanks ;) Kind of silly I realize, but I wanted to make sure that if I spend

Re: [PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-23 Thread Jim Jagielski
On Oct 22, 2007, at 7:20 PM, Jeff Trawick wrote: like 2.0/2.2/trunk I'm looking for a conceptual +1 out there. You got it. Conceptual +1 :)

[PATCH] fix 1.3's ap_proxy_date_canon error handling

2007-10-22 Thread Jeff Trawick
like 2.0/2.2/trunk I'm looking for a conceptual +1 out there. I've barely tested it and need to summarize the diffs between ap_ and apr_ functions again. (e.g., "apr_date_parse_http supports format XXX that ap_parseHTTPdate() doesn't support, but ap_proxy_date_canon() didn't allow that before an