The following patch should eliminate bogus error log entries similar to:
[Wed Sep 27 15:31:29 2006] [error] (-3)Unknown error 18446744073709551613: 
cache: error returned while trying to return disk cached data

If I have understood things right AP_FILTER_ERROR only means that an error has occured and that an error web page has already been sent (documented in CHANGES of all places). The additional garbage in the error log doesn't make anyone happy...


/Nikke
--
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     [EMAIL PROTECTED]
---------------------------------------------------------------------------
 "Don't give away the homeworld." - Babylon 5
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Index: mod_cache.c
===================================================================
--- mod_cache.c (revision 450405)
+++ mod_cache.c (working copy)
@@ -244,10 +244,12 @@ static int cache_url_handler(request_rec
     out = apr_brigade_create(r->pool, r->connection->bucket_alloc);
     rv = ap_pass_brigade(r->output_filters, out);
     if (rv != APR_SUCCESS) {
-        ap_log_error(APLOG_MARK, APLOG_ERR, rv, r->server,
-                     "cache: error returned while trying to return %s "
-                     "cached data",
-                     cache->provider_name);
+        if(rv != AP_FILTER_ERROR) {
+            ap_log_error(APLOG_MARK, APLOG_ERR, rv, r->server,
+                         "cache: error returned while trying to return %s "
+                         "cached data",
+                         cache->provider_name);
+        }
         return rv;
     }
 

Reply via email to