Re: [PATCH] worker MPM: reuse transaction pools

2001-09-10 Thread Aaron Bannert
On Mon, Sep 10, 2001 at 03:13:48PM -0700, Brian Pane wrote: > I suppose there are a total of four candidate designs, right? It looks > like you're varying two independent dimensions: > * condition variable strategy: one CV, or one per thread > * pool strategy: worker-managed, or listener-mana

Re: [PATCH] worker MPM: reuse transaction pools

2001-09-10 Thread Brian Pane
Aaron Bannert wrote: [...] >1) "short and sweet" > > - single listener > - creates a new transaction pool > - uses that pool for the next accept() > - push()es the newly accepted socket and pool on the fd_queue > > - multiple workers > - waiting in pop() on the fd_queue > - performs pr

Re: [PATCH] worker MPM: reuse transaction pools

2001-09-10 Thread Aaron Bannert
The patch in question was nothing more than an attempt to further improve worker, and was perhaps a little premature. I have, however, spent some time developing two possible alternative implementations of the worker MPM in addition to what is currently in CVS (which means that I don't expect what

Re: [PATCH] worker MPM: reuse transaction pools

2001-09-10 Thread dean gaudet
On Tue, 28 Aug 2001, Ryan Bloom wrote: > Creating a pool requires locking a mutex. The more we scale, the worse we > perform. a mutex is not a requirement... as i explained several months ago. (and as greg mentioned, this patch just moves the mutex to the queue from the pool code, which makes

Re: [PATCH] worker MPM: reuse transaction pools

2001-09-10 Thread dean gaudet
this is the wrong way to fix this problem. i can't imagine any reason why creating a pool should be slow -- rather than band-aid around it, i think it'd be better to find out that problem first. it should be as simple as a couple pointer operations. freelists are a feature of modern memory allo

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Greg Stein
On Tue, Aug 28, 2001 at 01:01:11PM -0700, Ryan Bloom wrote: > On Tuesday 28 August 2001 12:17, Greg Stein wrote: > > On Mon, Aug 27, 2001 at 05:09:01PM -0700, Aaron Bannert wrote: > > > This patch implements a resource pool of context pools -- a queue of >... > > IOW, why should this complexity be

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Aaron Bannert
On Tue, Aug 28, 2001 at 12:17:03PM -0700, Greg Stein wrote: > On Mon, Aug 27, 2001 at 05:09:01PM -0700, Aaron Bannert wrote: > > This patch implements a resource pool of context pools -- a queue of > > available pools that the listener thread can pull from when accepting > > a request. The worker

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Ryan Bloom
On Tuesday 28 August 2001 12:17, Greg Stein wrote: > On Mon, Aug 27, 2001 at 05:09:01PM -0700, Aaron Bannert wrote: > > This patch implements a resource pool of context pools -- a queue of > > available pools that the listener thread can pull from when accepting > > a request. The worker thread th

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Greg Stein
On Mon, Aug 27, 2001 at 05:09:01PM -0700, Aaron Bannert wrote: > This patch implements a resource pool of context pools -- a queue of > available pools that the listener thread can pull from when accepting > a request. The worker thread that picks up that request then uses > that pool for the life

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Ryan Bloom
On Tuesday 28 August 2001 07:04, Jeff Trawick wrote: > Ryan Bloom <[EMAIL PROTECTED]> writes: > > On Tuesday 28 August 2001 04:03, Jeff Trawick wrote: > > > Aaron Bannert <[EMAIL PROTECTED]> writes: > > > > This patch implements a resource pool of context pools -- a queue of > > > > available pool

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Jeff Trawick
Ryan Bloom <[EMAIL PROTECTED]> writes: > On Tuesday 28 August 2001 04:03, Jeff Trawick wrote: > > Aaron Bannert <[EMAIL PROTECTED]> writes: > > > This patch implements a resource pool of context pools -- a queue of > > > available pools that the listener thread can pull from when accepting > > >

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Ryan Bloom
On Tuesday 28 August 2001 04:03, Jeff Trawick wrote: > Aaron Bannert <[EMAIL PROTECTED]> writes: > > This patch implements a resource pool of context pools -- a queue of > > available pools that the listener thread can pull from when accepting > > a request. The worker thread that picks up that re

Re: [PATCH] worker MPM: reuse transaction pools

2001-08-28 Thread Jeff Trawick
Aaron Bannert <[EMAIL PROTECTED]> writes: > This patch implements a resource pool of context pools -- a queue of > available pools that the listener thread can pull from when accepting > a request. The worker thread that picks up that request then uses > that pool for the lifetime of that transac

[PATCH] worker MPM: reuse transaction pools

2001-08-27 Thread Aaron Bannert
This patch implements a resource pool of context pools -- a queue of available pools that the listener thread can pull from when accepting a request. The worker thread that picks up that request then uses that pool for the lifetime of that transaction, clear()ing the pool and releasing it back to