The limit checking is broken in 2.2's ap_get_scoreboard_*. This was
fixed in 2.4 in http://svn.apache.org/viewvc?view=revision&revision=417252
Patch below backports that, plus fixes the additional broken comparison
in ap_get_scoreboard_lb(), discovered by Hisanobu Okuda.
Can I get +1s for this
On Mon, Jun 19, 2017 at 2:08 PM, Joe Orton wrote:
> The limit checking is broken in 2.2's ap_get_scoreboard_*. This was
> fixed in 2.4 in http://svn.apache.org/viewvc?view=revision&revision=417252
>
> Patch below backports that, plus fixes the additional broken comparison
> in ap_get_scoreboard_l
+1 here... That gets you to 3. Good catch thanks.
On Jun 19, 2017 07:09, "Joe Orton" wrote:
> The limit checking is broken in 2.2's ap_get_scoreboard_*. This was
> fixed in 2.4 in http://svn.apache.org/viewvc?view=revision&revision=417252
>
> Patch below backports that, plus fixes the additiona
Joe, I compromised on your fix and retained parens for legibility,
following the pattern of the other fix.
Committed as r1799356, thanks
On Mon, Jun 19, 2017 at 7:08 AM, Joe Orton wrote:
> The limit checking is broken in 2.2's ap_get_scoreboard_*. This was
> fixed in 2.4 in http://svn.apache.or
On Tue, Jun 20, 2017 at 11:48:53AM -0500, William A Rowe Jr wrote:
> Joe, I compromised on your fix and retained parens for legibility,
> following the pattern of the other fix.
>
> Committed as r1799356, thanks
Thanks a lot Bill! I will survive the extra parentheses... :)
