Re: [PATCH 41743] Graceful restart with prefork mpm issue

2011-02-02 Thread Andrew Punch
Hi, I have double checked and the trunk does not fix this problem for *prefork*. r645434 does not fix this problem. Joe stated This does look insufficient to fix the bug for prefork It does raise a good point though. It would make sense to fix this in the trunk AND 2.2.x, rather than just 2.2.x

Re: [PATCH 41743] Graceful restart with prefork mpm issue

2011-02-02 Thread Andrew Punch
Hi, I have now created two patches: one for trunk and one for 2.2.x The approach I used is as follows. TRUNK = 1. Set the mpm_state to AP_MPMQ_STOPPING 2.2.x BRANCH 1. Set the mpm_state to AP_MPMQ_STOPPING 2. Return the correct value from ap_graceful_stop_signalled() I

[PATCH 41743] Graceful restart with prefork mpm issue

2011-02-01 Thread Andrew Punch
Hi, I have contributed a patch to the long-standing bug 41743. A summary of the issue is that if a keep-alive connection is active then the child process never exits in certain cases (see bug for full details). The expected behaviour, the behaviour of worker and the behaviour of 1.3 is that a

Re: [PATCH 41743] Graceful restart with prefork mpm issue

2011-02-01 Thread Ruediger Pluem
On 02/02/2011 12:57 AM, Andrew Punch wrote: Hi, I have contributed a patch to the long-standing bug 41743. A summary of the issue is that if a keep-alive connection is active then the child process never exits in certain cases (see bug for full details). The expected behaviour, the