Re: [RFC] Guide to writing output filters

2007-03-23 Thread Joe Orton
On Mon, Mar 19, 2007 at 10:15:03PM +0100, Ruediger Pluem wrote: [on passing empty brigades and mod_cache] > Once we detect that we have a fresh content entity in the cache, the > quick handler of mod_cache starts the filter chain by calling > > ap_pass_brigade(r->output_filters, out); > > where

Re: [RFC] Guide to writing output filters

2007-03-19 Thread Ruediger Pluem
On 03/19/2007 03:06 PM, Joe Orton wrote: > Thanks a lot for the review! > > On Sat, Mar 17, 2007 at 04:30:24PM +0100, Ruediger Pluem wrote: > >>Some comments from my side: >> >>- Passing empty brigades: While I agree that a filter should never create >> an empty brigade and pass it down the ch

Re: [RFC] Guide to writing output filters

2007-03-19 Thread Joe Orton
Again, thanks for the review! On Sat, Mar 17, 2007 at 07:44:02AM -0400, Jeff Trawick wrote: > I guess I'm confused about the up/down direction convention for output > filters? I thought passing the next output filter is "down" and > returning to the prior input filter is "up"? My confusion - I

Re: [RFC] Guide to writing output filters

2007-03-19 Thread Joe Orton
Thanks a lot for the review! On Sat, Mar 17, 2007 at 04:30:24PM +0100, Ruediger Pluem wrote: > Some comments from my side: > > - Passing empty brigades: While I agree that a filter should never create > an empty brigade and pass it down the chain, I think it actually should > pass an empty br

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Niklas Edmundsson
On Sat, 17 Mar 2007, Ruediger Pluem wrote: On 03/16/2007 11:55 PM, Joe Orton wrote: http://people.apache.org/~jorton/output-filters.html How does this look? Anything missed out, anything that doesn't make sense? I think this covers most of the major problems in output filters which keep comi

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Ruediger Pluem
On 03/16/2007 11:55 PM, Joe Orton wrote: > http://people.apache.org/~jorton/output-filters.html > > How does this look? Anything missed out, anything that doesn't make > sense? I think this covers most of the major problems in output filters > which keep coming up. Thanks for doing this. It

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Nick Kew
On Fri, 16 Mar 2007 22:55:21 + Joe Orton <[EMAIL PROTECTED]> wrote: > http://people.apache.org/~jorton/output-filters.html > > How does this look? Anything missed out, anything that doesn't make > sense? I think this covers most of the major problems in output > filters which keep coming u

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Jeff Trawick
On 3/16/07, Joe Orton <[EMAIL PROTECTED]> wrote: http://people.apache.org/~jorton/output-filters.html I guess I'm confused about the up/down direction convention for output filters? I thought passing the next output filter is "down" and returning to the prior input filter is "up"? a few exam

Re: [RFC] Guide to writing output filters

2007-03-17 Thread Ruediger Pluem
On 03/16/2007 11:55 PM, Joe Orton wrote: > http://people.apache.org/~jorton/output-filters.html > > How does this look? Anything missed out, anything that doesn't make > sense? I think this covers most of the major problems in output filters > which keep coming up. Thanks for doing this. It

[RFC] Guide to writing output filters

2007-03-16 Thread Joe Orton
http://people.apache.org/~jorton/output-filters.html How does this look? Anything missed out, anything that doesn't make sense? I think this covers most of the major problems in output filters which keep coming up. I'd also like to add a simple buffering filter which "does things right" and