Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-21 Thread Graham Leggett via dev
On 19 Apr 2024, at 09:01, Ruediger Pluem wrote: > First of all I haven't gone through the patch. Hence I may be off below. > > I think the core issue with the LDAP API we have in APR-UTIL 1.x today and > that let to the > removal discussions on APR side in 2010 >

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Yann Ylavic
On Thu, Apr 18, 2024 at 3:21 PM Joe Orton wrote: > > On Thu, Apr 18, 2024 at 09:40:21AM +0100, Graham Leggett via dev wrote: > > Hi all, > > > > The attached patch is a current work in progress patch for httpd-trunk to > > use the new apr_ldap API that just landing in APR. > > > > The

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Graham Leggett via dev
On 19 Apr 2024, at 09:07, Ruediger Pluem wrote: > Would it be possible to provide this patch as a PR against trunk on Github? I > think that would ease reviewing it. > I am quite aware that this moves some gory detail discussion of that patch > away from the dev list here and over > to the PR

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 10:40 AM, Graham Leggett via dev wrote: > Hi all, > > The attached patch is a current work in progress patch for httpd-trunk to use > the new apr_ldap API that just landing in APR. > > The highlights: > > - Complete replacement of the previous API. > - Will work against apr-2

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 3:21 PM, Joe Orton wrote: > On Thu, Apr 18, 2024 at 09:40:21AM +0100, Graham Leggett via dev wrote: >> Hi all, >> >> The attached patch is a current work in progress patch for httpd-trunk to >> use the new apr_ldap API that just landing in APR. >> >> The highlights: >> >> - Complete

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-18 Thread Graham Leggett via dev
On 18 Apr 2024, at 14:21, Joe Orton wrote: > This design decision seems surprising to me, what does this add? Adding > another abstraction layer to allow runtime selection of the LDAP library > seems like a step backwards (a lot of complexity with no benefit). > Unlike with e.g. a database

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-18 Thread Joe Orton
On Thu, Apr 18, 2024 at 09:40:21AM +0100, Graham Leggett via dev wrote: > Hi all, > > The attached patch is a current work in progress patch for httpd-trunk to use > the new apr_ldap API that just landing in APR. > > The highlights: > > - Complete replacement of the previous API. > - Will work