Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread SiPlus
Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's only constant arithmetic here, so I don't see a reason to pre-calculate the

Re: Pull request: server/util_md5.c:58 - replace magic number with constant arithmetic

2012-08-29 Thread pqf
Some C compilers don't support this: result[2*APR_MD5_DIGESTSIZE+1] ? Hello, dev@. I request a little change to HTTPD code. On line 58 of server/util_md5.c, please replace char *r, result[33]; /* (MD5_DIGESTSIZE * 2) + 1 */ with char *r, result[2*APR_MD5_DIGESTSIZE+1]; There's