Adding AddHandler support for mod_proxy

2014-02-06 Thread ryo takatsuki
Hi, I have an improvement request to suggest but I would like to first provide some background to justify it, I apologise for the long email :). I'm actively using mod_proxy to forward PHP files requests to PHP-FPM. My current approach is to use a RewriteRule with the 'P' flag because (in most of

Re: Adding AddHandler support for mod_proxy

2014-02-14 Thread ryo takatsuki
Hi all, Does anybody has any feedback on the patch ? Any concerns or suggestions? Thanks! 2014-02-06 16:03 GMT+01:00 ryo takatsuki : > Hi, > > I have an improvement request to suggest but I would like to first provide > some background to justify it, I apologise for the long email :). > > I'm

Re: Adding AddHandler support for mod_proxy

2014-02-16 Thread Lazy
2014-02-06 ryo takatsuki : > Hi, > > I have an improvement request to suggest but I would like to first provide > some background to justify it, I apologise for the long email :). > > I'm actively using mod_proxy to forward PHP files requests to PHP-FPM. My > current approach is to use a RewriteRul

Re: Adding AddHandler support for mod_proxy

2014-02-18 Thread ryo takatsuki
>AddHandler might be tricky from security point of view, eg. most of cms >software >usually checks only for last extension before writing uploaded files, >but this AddHandler will also >pass test.php.jpeg to php which might execute this Yes, It would be probably safer to use something like:

Re: Adding AddHandler support for mod_proxy

2014-02-26 Thread ryo takatsuki
Hi all, Any other comments about the patch? I believe it is simple enough and could ease the migration from mod_php to PHP-FPM (and make use of the new event mode) with minimal changes to the default configurations. Could you consider adding it? Pretty please :) To give more background, at Bitnam

Re: Adding AddHandler support for mod_proxy

2014-02-27 Thread Jim Jagielski
Thx for the patch! Let me take a look... I'm assuming that there's no real work-around other than the patch itself, right? On Feb 26, 2014, at 1:47 PM, ryo takatsuki wrote: > Hi all, > > Any other comments about the patch? I believe it is simple enough and > could ease the migration from mod_ph

Re: Adding AddHandler support for mod_proxy

2014-02-27 Thread ryo takatsuki
>Thx for the patch! Let me take a look... I'm assuming that there's >no real work-around other than the patch itself, right? If there is, we could not find it :) We have been searching for months and trying different approaches. This is required to work with out of the box installation of many app

Re: Adding AddHandler support for mod_proxy

2014-03-03 Thread Jim Jagielski
From what I can see, it's pretty useful and I'm not detecting any errors or issues which would cause a regression. Final testing will be done by COB today but I expect to fold it into trunk, while adding some doc info. On Feb 27, 2014, at 12:19 PM, ryo takatsuki wrote: >> Thx for the patch! Let

Re: Re: Adding AddHandler support for mod_proxy

2014-03-11 Thread Andreas Bosch
Am 27.02.2014 18:19, schrieb ryo takatsuki: Thx for the patch! Let me take a look... I'm assuming that there's no real work-around other than the patch itself, right? If there is, we could not find it :) We have been searching for months and trying different approaches. This is required to work

Re: Re: Adding AddHandler support for mod_proxy

2014-03-26 Thread ryo takatsuki
Hi, That is the first approach we used (in fact, that was how we also named it, mod_proxy_handler :)). The problem is that we support a lot of different scenarios, sometimes we bundle our own apache, and sometimes we use the native one from the system. In the former case, we are ok with patching A