Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-10 Thread Travis CI
Build Update for apache/httpd - Build: #804 Status: Broken Duration: 12 mins and 35 secs Commit: 97bc128 (trunk) Author: Ruediger Pluem Message: * Have the HTTP 0.9 / 1.1 processing code reject requests for HTTP >= 2.0 with a HTTP Version Not Support status c

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-10 Thread Ruediger Pluem
Sorry for not testing before and breaking stuff with r1878708. There are basically two failures here: 1. The test failure in t/apache/http_strict.t is because I missed to adjust the test and I think the following would do (at least it now passes again): Index: t/apache/http_strict.t

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-15 Thread Ruediger Pluem
I would like to unblock the test failure on trunk soon. Any comments on the below? Regards RĂ¼diger On 6/10/20 4:31 PM, Ruediger Pluem wrote: > Sorry for not testing before and breaking stuff with r1878708. There are > basically two failures here: > > 1. The test failure in t/apache/http_stric

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-16 Thread Stefan Eissing
> Am 15.06.2020 um 21:46 schrieb Ruediger Pluem : > > I would like to unblock the test failure on trunk soon. Any comments on the > below? I am not really familiar with ap_parse_request_line() and why it was added there. Yann? As to "faking" the http version of a request, that does not look go

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-16 Thread Ruediger Pluem
On 6/16/20 9:29 AM, Stefan Eissing wrote: >> Am 15.06.2020 um 21:46 schrieb Ruediger Pluem : >> >> I would like to unblock the test failure on trunk soon. Any comments on the >> below? > > I am not really familiar with ap_parse_request_line() and why it was added > there. Yann? > > As to "fa

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Joe Orton
On Tue, Jun 16, 2020 at 12:08:41PM +0200, Ruediger Pluem wrote: > > > On 6/16/20 9:29 AM, Stefan Eissing wrote: > >> Am 15.06.2020 um 21:46 schrieb Ruediger Pluem : > >> > >> I would like to unblock the test failure on trunk soon. Any comments on > >> the below? > > > > I am not really familiar

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Yann Ylavic
On Wed, Jun 17, 2020 at 10:43 AM Joe Orton wrote: > > > And yes this makes me think if this kind of fake really makes sense. The > > need to reset 3 request_rec fields after > > ap_parse_request_line doesn't sound good. At this point it isn't an HTTP/2 request IMHO, it's an HTTP/1 request extrac

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Ruediger Pluem
On 6/17/20 10:43 AM, Joe Orton wrote: > On Tue, Jun 16, 2020 at 12:08:41PM +0200, Ruediger Pluem wrote: >> >> >> On 6/16/20 9:29 AM, Stefan Eissing wrote: Am 15.06.2020 um 21:46 schrieb Ruediger Pluem : I would like to unblock the test failure on trunk soon. Any comments on

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Stefan Eissing
I just read ap_parse_request_line() again. It seems to consist of 2 parts: 1. the parsing of the text line into protocol/method/uri bits with error checks 2. the check on method/uri correctness in combination with some protocol version specific checks I think the 2nd part is vital to run for ev

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Ruediger Pluem
On 6/17/20 11:52 AM, Yann Ylavic wrote: > On Wed, Jun 17, 2020 at 10:43 AM Joe Orton wrote: >> >>> And yes this makes me think if this kind of fake really makes sense. The >>> need to reset 3 request_rec fields after >>> ap_parse_request_line doesn't sound good. > > At this point it isn't an

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-17 Thread Ruediger Pluem
On 6/17/20 3:11 PM, Ruediger Pluem wrote: > > > On 6/17/20 11:52 AM, Yann Ylavic wrote: >> On Wed, Jun 17, 2020 at 10:43 AM Joe Orton wrote: >>> And yes this makes me think if this kind of fake really makes sense. The need to reset 3 request_rec fields after ap_parse_request_l

Re: Broken: apache/httpd#804 (trunk - 97bc128)

2020-06-18 Thread Stefan Eissing
> Am 17.06.2020 um 21:19 schrieb Ruediger Pluem : > > > > On 6/17/20 3:11 PM, Ruediger Pluem wrote: >> >> >> On 6/17/20 11:52 AM, Yann Ylavic wrote: >>> On Wed, Jun 17, 2020 at 10:43 AM Joe Orton wrote: > And yes this makes me think if this kind of fake really makes sense. The