Re: Code questions (server/protocol.c)

2002-03-12 Thread Justin Erenkrantz
On Mon, Mar 11, 2002 at 03:03:02PM +0100, Sander Striker wrote: Hi, server/protocol.c:136 if (ap_strcasestr(type, charset=) != NULL) { /* already has parameter, do nothing */ /* XXX we don't check the validity */ ; } Validity checking seems like a good

RE: Code questions (server/protocol.c)

2002-03-12 Thread Ryan Bloom
server/protocol.c:1290 AP_DECLARE(size_t) ap_send_mmap(apr_mmap_t *mm, request_rec *r, size_t offset, size_t length) I reckon the size_t's are left here intentional, weren't forgotten when switching to apr_size_t? Does anything use this? I can't

Code questions (server/protocol.c)

2002-03-11 Thread Sander Striker
Hi, server/protocol.c:136 if (ap_strcasestr(type, charset=) != NULL) { /* already has parameter, do nothing */ /* XXX we don't check the validity */ ; } Validity checking seems like a good idea, someone want to grab this one? server/protocol.c:658 #if 0 /* XXX