Re: PR 31759 - default handler returns output filter apr_status_t value

2006-04-01 Thread Ruediger Pluem
On 04/02/2006 12:27 AM, Jeff Trawick wrote: > > yep ;) > > I'll move the patch to trunk, change it to return OK where original > patch returned r->status, integrate your logging patch, and commit, if > it holds up under more varied testing. > Thanks.

Re: PR 31759 - default handler returns output filter apr_status_t value

2006-04-01 Thread Jeff Trawick
On 4/1/06, Ruediger Pluem <[EMAIL PROTECTED]> wrote: > > > On 03/31/2006 06:53 PM, Jeff Trawick wrote: > > > > > Some concerns about the else path: > > > > a) is 500 proper? should it just return OK instead? > > I think 500 is good. > > > > > b) what about logging that path to ensure that the admi

Re: PR 31759 - default handler returns output filter apr_status_t value

2006-04-01 Thread Ruediger Pluem
On 03/31/2006 06:53 PM, Jeff Trawick wrote: > > Some concerns about the else path: > > a) is 500 proper? should it just return OK instead? I think 500 is good. > > b) what about logging that path to ensure that the administrator has > some help diagnosing the problem, since we can't carry

PR 31759 - default handler returns output filter apr_status_t value

2006-03-31 Thread Jeff Trawick
Some discussion has taken place in bugzilla but more discussion and opinions are needed. A patch recently posted: Index: server/core.c === --- server/core.c (revision 386843) +++ server/core.c (working copy) @@ -3645,7 +3