Re: Proxy's pre_request and post_request hooks

2008-02-27 Thread Jim Jagielski
I'm looking at adding 2 new hooks proxy_hook_pre_shandler and proxy_hook_post_shandler which run right before/after scheme_handler (or after/before pre_request/post_request) to add the functionality that the existing hooks don't... Mainly, this is so it can live in trunk, be tested there and then

Re: Proxy's pre_request and post_request hooks

2008-02-16 Thread Jim Jagielski
On Feb 16, 2008, at 8:55 AM, Dirk-Willem van Gulik wrote: On Feb 15, 2008, at 7:12 PM, Jim Jagielski wrote: On Feb 14, 2008, at 3:07 PM, Jim Jagielski wrote: Soo I'm proposing changing to RUN_ALL... Bueller...? Bueller...? Just been playing a bit - but fail to understand how thi

Re: Proxy's pre_request and post_request hooks

2008-02-16 Thread Dirk-Willem van Gulik
On Feb 15, 2008, at 7:12 PM, Jim Jagielski wrote: On Feb 14, 2008, at 3:07 PM, Jim Jagielski wrote: Soo I'm proposing changing to RUN_ALL... Bueller...? Bueller...? Just been playing a bit - but fail to understand how this can be made to work for anything old ? Or am I misunderst

Re: Proxy's pre_request and post_request hooks

2008-02-15 Thread Graham Leggett
Jim Jagielski wrote: Soo I'm proposing changing to RUN_ALL... Comments? It makes sense, the question though would be whether it could be done in a way that is backwards compatible. Regards, Graham -- smime.p7s Description: S/MIME Cryptographic Signature

Re: Proxy's pre_request and post_request hooks

2008-02-15 Thread Jim Jagielski
On Feb 15, 2008, at 1:21 PM, Nick Kew wrote: On Thu, 14 Feb 2008 15:07:38 -0500 Jim Jagielski <[EMAIL PROTECTED]> wrote: Right now, both of these are defined as APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST and the ones we use are at APR_HOOK_FIRST. They also always return OK (unless an error) so thi

Re: Proxy's pre_request and post_request hooks

2008-02-15 Thread Nick Kew
On Thu, 14 Feb 2008 15:07:38 -0500 Jim Jagielski <[EMAIL PROTECTED]> wrote: > Right now, both of these are defined as > APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST and the ones we use > are at APR_HOOK_FIRST. They also always return OK (unless > an error) so this means that we can never add additional >

Re: Proxy's pre_request and post_request hooks

2008-02-15 Thread Jim Jagielski
On Feb 14, 2008, at 3:07 PM, Jim Jagielski wrote: Soo I'm proposing changing to RUN_ALL... Bueller...? Bueller...?

Proxy's pre_request and post_request hooks

2008-02-14 Thread Jim Jagielski
Right now, both of these are defined as APR_IMPLEMENT_EXTERNAL_HOOK_RUN_FIRST and the ones we use are at APR_HOOK_FIRST. They also always return OK (unless an error) so this means that we can never add additional hooks here and have them run (don't talk to me about REALLY_FIRST :) ). Anyway, cons