Question about memory allocation in 'substring_conf' (server/util.c)

2013-02-05 Thread Marion Christophe JAILLET
Hi, This may look useless, but I can't figure out why in function 'substring_conf' (line 752 in server/util.c) we allocate len+2 bytes ? This seems to have been like that forever. IMO, len+1 should be enough. Changing that would be a huge memory usage improvement :). Does any one has an

Re: Question about memory allocation in 'substring_conf' (server/util.c)

2013-02-05 Thread Jeff Trawick
On Tue, Feb 5, 2013 at 3:50 PM, Marion Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Hi, This may look useless, but I can't figure out why in function 'substring_conf' (line 752 in server/util.c) we allocate len+2 bytes ? This seems to have been like that forever. IMO, len+1

Re: Question about memory allocation in 'substring_conf' (server/util.c)

2013-02-05 Thread Christophe JAILLET
Le 05/02/2013 21:58, Jeff Trawick a écrit : Changing that would be a huge memory usage improvement :). needs more study Not surprising, changing it has no impact on the result of 'top' on my development machine. Anyway, I'll propose a patch. BTW, is there a way to easily dump a