RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-10-02 Thread Lu, Yingqi
patch with SO_REUSEPORT support Thanks very much for your help! -Original Message- From: Jim Jagielski [mailto:j...@jagunet.com] Sent: Thursday, June 05, 2014 6:38 AM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Committed r1600656

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-05 Thread Lu, Yingqi
Thanks very much for your help! -Original Message- From: Jim Jagielski [mailto:j...@jagunet.com] Sent: Thursday, June 05, 2014 6:38 AM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Committed r1600656 Thx On Jun 4, 2014, at

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-05 Thread Jim Jagielski
SF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT > support > > Thank you very much for your help! > > Thanks, > Yingqi > > -Original Message- > From: Jim Jagielski [mailto:j...@jagunet.com] > Sent: Tuesday, June 03, 2014 8:31 AM > To: dev@httpd.a

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-04 Thread Lu, Yingqi
- From: Lu, Yingqi [mailto:yingqi...@intel.com] Sent: Tuesday, June 03, 2014 8:50 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Thank you very much for your help! Thanks, Yingqi -Original Message- From: Jim Jagielski

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Lu, Yingqi
Thank you very much for your help! Thanks, Yingqi -Original Message- From: Jim Jagielski [mailto:j...@jagunet.com] Sent: Tuesday, June 03, 2014 8:31 AM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Next on the agenda is to

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
6279. >>> >>> Thanks, >>> Yingqi >>> >>> -----Original Message- >>> From: Lu, Yingqi [mailto:yingqi...@intel.com] >>> Sent: Saturday, May 31, 2014 11:48 PM >>> To: dev@httpd.apache.org >>> Subject: RE: [PATCH A

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
sing. >> >> I already updated the Bugzilla database for the item 55897 and item 56279. >> >> Thanks, >> Yingqi >> >> -Original Message- >> From: Lu, Yingqi [mailto:yingqi...@intel.com] >> Sent: Saturday, May 31, 2014 11:48 PM >

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-03 Thread Jim Jagielski
you think is better. I can quickly send you an > update for review. > > Thanks, > Yingqi > > -Original Message- > From: Lu, Yingqi > Sent: Saturday, May 31, 2014 3:28 PM > To: > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT >

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-02 Thread Marion et Christophe JAILLET
Hi,   see http://httpd.apache.org/lists.html#http-dev You should just send a mail to  dev-unsubscr...@httpd.apache.org.   best regards,   CJ > Message du 02/06/14 16:16 > De : "Mihai Iacob" > A : dev@httpd.apache.org > Copie à : > Objet : Re: [PATCH ASF bu

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-02 Thread Mihai Iacob
55897 and item 56279. > > Thanks, > Yingqi > > -Original Message- > From: Lu, Yingqi [mailto:yingqi...@intel.com] > Sent: Saturday, May 31, 2014 11:48 PM > To: dev@httpd.apache.org > Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support &

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-06-02 Thread Jim Jagielski
item 56279. > > Thanks, > Yingqi > > -Original Message- > From: Lu, Yingqi [mailto:yingqi...@intel.com] > Sent: Saturday, May 31, 2014 11:48 PM > To: dev@httpd.apache.org > Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT > support > > Hi Jim

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Lu, Yingqi
() itself. >> >>> On May 30, 2014, at 11:15 AM, Lu, Yingqi wrote: >>> >>> Thank you very much! >>> >>> Thanks, >>> Yingqi >>> >>> -Original Message- >>> From: Jim Jagielski [mailto:j...@jagunet.com] >>&

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Lu, Yingqi
gt; >>>> Hi Jim, >>>> >>>> Thanks very much for clarifying this with me. I added #ifdef in the code >>>> to check _SC_NPROCESSORS_ONLN in the so_reuseport patch. Bucket patch does >>>> not use this parameter so that it remains the sa

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Jim Jagielski
; -Original Message----- >> From: Jim Jagielski [mailto:j...@jagunet.com] >> Sent: Friday, May 30, 2014 7:07 AM >> To: dev@httpd.apache.org >> Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT >> support >> >> Thx! Let me review. My pl

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-31 Thread Jim Jagielski
ay, May 30, 2014 7:07 AM > To: dev@httpd.apache.org > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT > support > > Thx! Let me review. My plan is to fold into trunk this weekend. > > On May 16, 2014, at 2:53 PM, Lu, Yingqi wrote: > >> Hi Jim, >

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-30 Thread Lu, Yingqi
Thank you very much! Thanks, Yingqi -Original Message- From: Jim Jagielski [mailto:j...@jagunet.com] Sent: Friday, May 30, 2014 7:07 AM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Thx! Let me review. My plan is to fold

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-30 Thread Mihai Iacob
m] > Sent: Thursday, May 15, 2014 7:53 AM > To: dev@httpd.apache.org > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support > > I was thinking more about the sysconf(_SC_NPROCESSORS_ONLN) stuff... > We could either check for that during config/build

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-30 Thread Jim Jagielski
ent: Thursday, May 15, 2014 7:53 AM > To: dev@httpd.apache.org > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT > support > > I was thinking more about the sysconf(_SC_NPROCESSORS_ONLN) stuff... > We could either check for that during config/build or protect it wit

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-28 Thread Lu, Yingqi
Hi All, I just want to ping again on these two patches. Thanks, Yingqi -Original Message- From: Lu, Yingqi [mailto:yingqi...@intel.com] Sent: Friday, May 23, 2014 9:03 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-23 Thread Lu, Yingqi
trunk? Thanks, Yingqi -Original Message- From: Lu, Yingqi [mailto:yingqi...@intel.com] Sent: Friday, May 16, 2014 11:53 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Jim, Thanks very much for clarifying this with me. I

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-20 Thread Lu, Yingqi
] Sent: Friday, May 16, 2014 11:53 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Jim, Thanks very much for clarifying this with me. I added #ifdef in the code to check _SC_NPROCESSORS_ONLN in the so_reuseport patch. Bucket patch

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-16 Thread Lu, Yingqi
Dear all, Any other feedback/comments/questions? Thanks, Yingqi -Original Message- From: Lu, Yingqi Sent: Wednesday, May 14, 2014 9:00 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Jim, Thanks very much for your

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-16 Thread Lu, Yingqi
Dear all, Any other feedback/comments/questions? Thanks, Yingqi -Original Message- From: Lu, Yingqi Sent: Wednesday, May 14, 2014 9:00 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Jim, Thanks very much for your

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-16 Thread Lu, Yingqi
Sent: Wednesday, May 14, 2014 9:00 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Jim, Thanks very much for your email. In the SO_REUSEPORT patch, SO_REUSEPORT support is checked inside listen.c file. If the feature is not

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-16 Thread Jim Jagielski
: Wednesday, May 14, 2014 6:57 AM > To: dev@httpd.apache.org > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT > support > > This is very cool! > > mod_status assumes that sysconf() exists, but do we need to do a config check > on the para

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-16 Thread Lu, Yingqi
org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support This is very cool! mod_status assumes that sysconf() exists, but do we need to do a config check on the params we use in these patches? We look OK on Linux, FreeBSD and OSX... I'm +1 on folding into tr

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-14 Thread Lu, Yingqi
TCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support This is very cool! mod_status assumes that sysconf() exists, but do we need to do a config check on the params we use in these patches? We look OK on Linux, FreeBSD and OSX... I'm +1 on folding into trunk. On May 13, 2014,

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-05-14 Thread Jim Jagielski
This is very cool! mod_status assumes that sysconf() exists, but do we need to do a config check on the params we use in these patches? We look OK on Linux, FreeBSD and OSX... I'm +1 on folding into trunk. On May 13, 2014, at 7:55 PM, Lu, Yingqi wrote: > Dear All, > > During the last couple

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-04-07 Thread Lu, Yingqi
Thanks, Graham! I am looking forward to hearing your feedback. Thanks, Yingqi From: Graham Leggett [mailto:minf...@sharp.fm] Sent: Monday, April 07, 2014 12:08 PM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support On 07 Apr 2014, at 6

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-04-07 Thread Graham Leggett
On 07 Apr 2014, at 6:21 PM, "Lu, Yingqi" wrote: > I just want to ping again on the modifications we made on both of the patches > [bugzilla #55897 and bugzilla #56279]. Please let us know your comments and > feedback. > > I am reattaching the patch files here in case you missed original email

RE: [PATCH ASF bugzilla# 55897] prefork_mpm patch with SO_REUSEPORT support

2014-03-17 Thread Lu, Yingqi
Bannister [mailto:is...@jellybaby.net] Sent: Monday, March 17, 2014 2:31 PM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897] prefork_mpm patch with SO_REUSEPORT support I'm afraid I don't understand this particular part from httpd_trunk_so_reuseport.patch: #ifndef SO_REUSEPO

Re: [PATCH ASF bugzilla# 55897] prefork_mpm patch with SO_REUSEPORT support

2014-03-17 Thread Tim Bannister
I'm afraid I don't understand this particular part from httpd_trunk_so_reuseport.patch: #ifndef SO_REUSEPORT #define SO_REUSEPORT 15 #endif Why 15? Is this going to be portable across different platforms? -- Tim Bannister – is...@jellybaby.net

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Lu, Yingqi
defined in the httpd.conf file. Thanks, Yingqi From: Yann Ylavic [mailto:ylavic@gmail.com] Sent: Thursday, March 06, 2014 5:49 AM To: httpd Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support On Wed, Mar 5, 2014 at 6:38 PM, Lu, Yingqi mailto:yingqi

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Yann Ylavic
t; > >> ++1. > >> > >> > >> On Mar 6, 2014, at 3:15 AM, Plüm, Rüdiger, Vodafone Group > >> wrote: > >> > >> > > >> > > >> >> -Original Message- > >> >> From: William A. Rowe Jr. [mai

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread William A. Rowe Jr.
>> >> On Mar 6, 2014, at 3:15 AM, Plüm, Rüdiger, Vodafone Group >> wrote: >> >> > >> > >> >> -Original Message- >> >> From: William A. Rowe Jr. [mailto:wmr...@gmail.com] >> >> Sent: Donnerstag, 6. März 2014 06:58 >> >>

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Yann Ylavic
lliam A. Rowe Jr. [mailto:wmr...@gmail.com] > >> Sent: Donnerstag, 6. März 2014 06:58 > >> To: dev@httpd.apache.org > >> Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with > >> SO_REUSEPORT support > >> > >> > >> If you

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread William A. Rowe Jr.
On Wed, Mar 5, 2014 at 11:38 AM, Lu, Yingqi wrote: > 1. If I understand correctly (please correct me if not), do you suggest > duplicating the listen socks inside the child process with SO_REUSEPROT > enabled? Yes, I agree this would be a cleaner implementation and I actually > tried that before.

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Jim Jagielski
++1. On Mar 6, 2014, at 3:15 AM, Plüm, Rüdiger, Vodafone Group wrote: > > >> -Original Message- >> From: William A. Rowe Jr. [mailto:wmr...@gmail.com] >> Sent: Donnerstag, 6. März 2014 06:58 >> To: dev@httpd.apache.org >> Subject: Re: [PATCH A

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Yann Ylavic
pen source and Apache community. We are > still on the learning curve about a lot of things. Your feedback and > comments really help us! > > > > Please let me know if you have any further questions. > > > > Thanks, > > Yingqi > > > > > > *From:*

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Graham Leggett
On 06 Mar 2014, at 10:15 AM, "Plüm, Rüdiger, Vodafone Group" wrote: > +1 to a new MPM on trunk. This gives it more time to settle and to stabilize > without disrupting current stuff. And if it is fast and stable it will > certainly > cause the 'older' MPM to drop in userbase :-). > IMHO this wo

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-06 Thread Plüm , Rüdiger , Vodafone Group
> -Original Message- > From: William A. Rowe Jr. [mailto:wmr...@gmail.com] > Sent: Donnerstag, 6. März 2014 06:58 > To: dev@httpd.apache.org > Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with > SO_REUSEPORT support > > > If you want to truly r

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread Lu, Yingqi
, 2014 9:58 PM To: dev@httpd.apache.org Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Yingqi, as one of the 'Windows folks' here, your idea is very intriguing, and I'm sorry that other issues have distracted me from giving it the attention it de

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread Arkadiusz Miśkiewicz
On Thursday 06 of March 2014, William A. Rowe Jr. wrote: > If you want to truly re-architect the MPM, by all means, propose it as > another MPM module. If it isn't adopted here, please don't hesitate > to offer it to interested users as separate source (although I hope we > find a way to adopt it

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread William A. Rowe Jr.
Yingqi, as one of the 'Windows folks' here, your idea is very intriguing, and I'm sorry that other issues have distracted me from giving it the attention it deserves. If you want to truly re-architect the MPM, by all means, propose it as another MPM module. If it isn't adopted here, please don't

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread Lu, Yingqi
ann Ylavic [mailto:ylavic@gmail.com] Sent: Wednesday, March 05, 2014 5:04 AM To: httpd Subject: Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi Yingqi, I'm a bit confused about the patch, mainly because it seems to handle the same way both with and without

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread Yann Ylavic
On Wed, Mar 5, 2014 at 2:04 PM, Yann Ylavic wrote: > Also, but this is not related to this patch particularly (addressed to > who knows), it's unclear to me why an accept mutex is needed at all. > Multiple processes poll()ing the same inherited socket is safe but not > multiple ones? Is that an O

Re: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-03-05 Thread Yann Ylavic
Hi Yingqi, I'm a bit confused about the patch, mainly because it seems to handle the same way both with and without SO_REUSEPORT available, while SO_REUSEPORT could (IMHO) be handled in children only (a less intrusive way). With SO_REUSEPORT, I would have expected the accept mutex to be useless s

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-02-10 Thread Lu, Yingqi
I am reattaching the patch in case you missed the original email. Thanks, Yingqi From: Lu, Yingqi Sent: Monday, February 10, 2014 11:09 AM To: dev@httpd.apache.org Subject: RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Hi All, I just want to ping again on this

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-02-10 Thread Lu, Yingqi
Hi All, I just want to ping again on this patch to see if there are any feedback and comments. This is our first patch to the Apache community. Please let us know if there is anything we can do to help you test and comment the patch. Thanks, Yingqi From: Lu, Yingqi Sent: Friday, January 24, 20

RE: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support

2014-01-31 Thread Lu, Yingqi
Hi All, I just want to check if there are feedback/comments to this patch? Thanks, Yingqi From: Lu, Yingqi Sent: Friday, January 24, 2014 3:26 PM To: dev@httpd.apache.org Subject: [PATCH ASF bugzilla# 55897]prefork_mpm patch with SO_REUSEPORT support Dear All, Our analysis of Apache httpd 2.4.