--On Thursday, October 31, 2002 12:19 AM -0600 "William A. Rowe, Jr."
<[EMAIL PROTECTED]> wrote:
OpenSSL 0.9.6g does so. Why shouldn't we?
Because OpenSSL is a library, we're not.
However, if we don't have inl worth of bytes, and they are sitting
ready (on the socket) shouldn't we fetch them
On Wed, Oct 30, 2002 at 09:04:02PM -0800, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
wrote:
> Well, I'm of the view that one should avoid declaring variables within a
> loop whenever possible. (you know - individual preferences etc.).
FWIW, I am too. :)
-aaron
At 10:51 PM 10/30/2002, Justin Erenkrantz wrote:
I haven't tested the patch, so I can't speak to whether the whole thing is busted or
not. => -- justin
The whole patch is busted for one reason... apr_bucket_read
never consumes any bytes. apr_brigade_read is what I really
should have used here
At 10:42 PM 10/30/2002, Justin Erenkrantz wrote:
>--On Wednesday, October 30, 2002 5:56 PM -0600 "William A. Rowe, Jr."
><[EMAIL PROTECTED]> wrote:
>
>>@@ -358,6 +357,12 @@
>> SSLConnRec *sslconn = myConnConfig(inbio->f->c);
>> int len = 0;
>>
>>+inbio->rc = APR_SUCCESS;
>>+
>>+/*
At 09:57 PM 10/30/2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
>+1 on the collapsing of ssl_io_hook_read() and ssl_io_input_read(). I think
>it's really good. Some observations about the patch :
>
>1. I think "apr_bucket *bucket" might be better out of the while() loop
>rather than within
> -Original Message-
> From: Justin Erenkrantz [mailto:jerenkrantz@;apache.org]
[snip]
> > @@ -366,11 +371,11 @@
> > BIO_bucket_flush(inbio->wbio);
> > }
> >
> > -inbio->rc = APR_SUCCESS;
> > -
> > +BIO_clear_retry_flags(bio);
> > +
> > /* first use data already r
Madhu
> -Original Message-
> From: Justin Erenkrantz [mailto:jerenkrantz@;apache.org]
> Sent: Wednesday, October 30, 2002 8:52 PM
> To: [EMAIL PROTECTED]
> Subject: RE: SSL Input Filter bogosity
>
>
> --On Wednesday, October 30, 2002 7:57 PM -0800 "MATHIHALLI,MADHUSU
--On Wednesday, October 30, 2002 7:57 PM -0800 "MATHIHALLI,MADHUSUDAN
(HP-Cupertino,ex1)" <[EMAIL PROTECTED]> wrote:
1. I think "apr_bucket *bucket" might be better out of the while()
loop rather than within the while(). But, with/without that change,
it doesn't work for me. Rather, using inbio->
--On Wednesday, October 30, 2002 5:56 PM -0600 "William A. Rowe, Jr."
<[EMAIL PROTECTED]> wrote:
@@ -358,6 +357,12 @@
SSLConnRec *sslconn = myConnConfig(inbio->f->c);
int len = 0;
+inbio->rc = APR_SUCCESS;
+
+/* OpenSSL catches this case, so should we. */
+if (!in)
+
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
> Subject: RE: SSL Input Filter bogosity
>
>
> +1 on the collapsing of ssl_io_hook_read() and
> ssl_io_input_read(). I think it's really good. Some
> observations about the patch :
>
> 1. I think "apr_bucket *bucket&quo
+1 on the collapsing of ssl_io_hook_read() and ssl_io_input_read(). I think
it's really good. Some observations about the patch :
1. I think "apr_bucket *bucket" might be better out of the while() loop
rather than within the while(). But, with/without that change, it doesn't
work for me. Rather, u
11 matches
Mail list logo