Re: Random AH01842 errors in mod_session_crypto

2016-12-02 Thread William A Rowe Jr
On Fri, Dec 2, 2016 at 4:28 PM, Yann Ylavic wrote: > On Fri, Dec 2, 2016 at 10:06 PM, Yann Ylavic wrote: > > On Wed, Oct 5, 2016 at 12:23 PM, Yann Ylavic > wrote: > >> > >> Patch attached, WDYT? > > > > Ping, probably is worth

Re: Random AH01842 errors in mod_session_crypto

2016-12-02 Thread Yann Ylavic
On Fri, Dec 2, 2016 at 10:06 PM, Yann Ylavic wrote: > On Wed, Oct 5, 2016 at 12:23 PM, Yann Ylavic wrote: >> >> Patch attached, WDYT? > > Ping, probably is worth considering for 1.6 (even 1.5) ? Committed to APR trunk (r1772414), 1.6.x (r1772415) and

Re: Random AH01842 errors in mod_session_crypto

2016-12-02 Thread William A Rowe Jr
On Fri, Dec 2, 2016 at 3:06 PM, Yann Ylavic wrote: > On Wed, Oct 5, 2016 at 12:23 PM, Yann Ylavic wrote: > > > > Patch attached, WDYT? > > Ping, probably is worth considering for 1.6 (even 1.5) ? > Provided you don't *break* the API contract with

Re: Random AH01842 errors in mod_session_crypto

2016-12-02 Thread Yann Ylavic
On Wed, Oct 5, 2016 at 12:23 PM, Yann Ylavic wrote: > > Patch attached, WDYT? Ping, probably is worth considering for 1.6 (even 1.5) ? > > Regards, > Yann.

Re: Random AH01842 errors in mod_session_crypto

2016-10-05 Thread Yann Ylavic
[Adding dev@apr, with a little abstract] On Mon, Sep 12, 2016 at 10:31 AM, Ewald Dieterich wrote: > > Looks like the problem is this: > > * In session_crypto_init() a crypto context is created from a global pool > (server->pconf). > * In encrypt_string() and decrypt_string() a

Re: Random AH01842 errors in mod_session_crypto

2016-10-04 Thread Yann Ylavic
On Tue, Oct 4, 2016 at 5:29 PM, Graham Leggett wrote: > On 4 Oct 2016, at 15:47, Paul Spangler wrote: > >> From my understanding, apr_crypto_key_t is an opaque struct defined >> separately by each crypto provider, so mod_session_crypto will not be able

Re: Random AH01842 errors in mod_session_crypto

2016-10-04 Thread Paul Spangler
On 10/4/2016 10:29 AM, Graham Leggett wrote: On 4 Oct 2016, at 15:47, Paul Spangler wrote: From my understanding, apr_crypto_key_t is an opaque struct defined separately by each crypto provider, so mod_session_crypto will not be able to do the sizeof. That's a sizeof

Re: Random AH01842 errors in mod_session_crypto

2016-10-04 Thread Graham Leggett
On 4 Oct 2016, at 15:47, Paul Spangler wrote: > From my understanding, apr_crypto_key_t is an opaque struct defined > separately by each crypto provider, so mod_session_crypto will not be able to > do the sizeof. That's a sizeof a pointer to apr_crypto_key_t, not the

Re: Random AH01842 errors in mod_session_crypto

2016-10-04 Thread Paul Spangler
On 9/12/2016 2:41 PM, Yann Ylavic wrote: On Mon, Sep 12, 2016 at 10:31 AM, Ewald Dieterich wrote: On 06/13/2016 09:38 AM, Ewald Dieterich wrote: Looks like the problem is this: Thanks for invertigating! Yes, I recently found a case where this error comes up as well and

Re: Random AH01842 errors in mod_session_crypto

2016-09-12 Thread Yann Ylavic
On Mon, Sep 12, 2016 at 10:31 AM, Ewald Dieterich wrote: > On 06/13/2016 09:38 AM, Ewald Dieterich wrote: > > Looks like the problem is this: Thanks for invertigating! > > * In session_crypto_init() a crypto context is created from a global pool > (server->pconf). > * In

Re: Random AH01842 errors in mod_session_crypto

2016-09-12 Thread Ewald Dieterich
On 06/13/2016 09:38 AM, Ewald Dieterich wrote: I configured form authentication with mod_auth_form, mod_session_cookie and mod_session_crypto in Apache 2.4.20 on Debian unstable and get random AH01842 errors ("decrypt session failed, wrong passphrase"). The passphrase was not changed when this