Re: Review desired - mod_ident

2003-01-16 Thread André Malo
* Justin Erenkrantz wrote: > --On Thursday, January 16, 2003 5:09 PM +0100 André Malo > <[EMAIL PROTECTED]> wrote: > >> Another question: I guess, the change does require an MMN bump, >> doesn't it? > > Well, I'm not real sure if we consider core_dir_config a part of our > public structures. I

Re: Review desired - mod_ident

2003-01-16 Thread Greg Ames
Justin Erenkrantz wrote: --On Thursday, January 16, 2003 5:09 PM +0100 André Malo <[EMAIL PROTECTED]> wrote: Another question: I guess, the change does require an MMN bump, doesn't it? Well, I'm not real sure if we consider core_dir_config a part of our public structures. I really don't see

Re: Review desired - mod_ident

2003-01-16 Thread Justin Erenkrantz
--On Thursday, January 16, 2003 5:09 PM +0100 André Malo <[EMAIL PROTECTED]> wrote: Another question: I guess, the change does require an MMN bump, doesn't it? Well, I'm not real sure if we consider core_dir_config a part of our public structures. I really don't see why a module would be play

Re: Review desired - mod_ident

2003-01-16 Thread André Malo
* Justin Erenkrantz wrote: > --On Wednesday, January 15, 2003 2:32 AM +0100 André Malo > <[EMAIL PROTECTED]> wrote: > >> I'd like to let someone review before committing, because it's at >> least a bunch of core changes. > > Looks good upon cursory review. I think we could optimize some of > t

Re: Review desired - mod_ident (was: move RFC 1413 out ofcore?)

2003-01-15 Thread Justin Erenkrantz
--On Wednesday, January 15, 2003 2:32 AM +0100 André Malo <[EMAIL PROTECTED]> wrote: I'd like to let someone review before committing, because it's at least a bunch of core changes. Looks good upon cursory review. I think we could optimize some of the socket calls (short read/write cases), b

Review desired - mod_ident (was: move RFC 1413 out of core?)

2003-01-14 Thread André Malo
* Justin Erenkrantz wrote: > --On Monday, January 13, 2003 1:13 AM +0100 André Malo <[EMAIL PROTECTED]> > wrote: > >> hmm, I'd like to move the ident code out of core into a separate >> module, say "mod_ident", since it's a feature, which is hardly >> used in more than 1% of the cases, where th