Revisiting the pre_htaccess hook

2013-06-09 Thread Stefan Fritsch
Hi, first of all, sorry that it took me so long to review at this. The current pre_access hook is executed before opening the htaccess and then can abort the request with a HTTP error code. Wouldn't a hook for opening the htaccess file make more sense because it would have more possible use ca

Re: Revisiting the pre_htaccess hook

2013-06-09 Thread Steinar H. Gunderson
On Sun, Jun 09, 2013 at 11:57:54AM +0200, Stefan Fritsch wrote: > Wouldn't a hook for opening the htaccess file make more sense because > it would have more possible use cases? Then modules could use this > hook to find htaccess files somewhere else, generate/extend/filter > them on the fly, etc

Re: Revisiting the pre_htaccess hook

2013-06-25 Thread Jeff Trawick
On Sun, Jun 9, 2013 at 5:57 AM, Stefan Fritsch wrote: > Hi, > > first of all, sorry that it took me so long to review at this. > > The current pre_access hook is executed before opening the htaccess > and then can abort the request with a HTTP error code. > > Wouldn't a hook for opening the htacc

Re: Revisiting the pre_htaccess hook

2013-06-26 Thread Jim Jagielski
I like the idea as well... The only issue I see is wondering if/when we'll have the implementation. On Jun 25, 2013, at 9:12 AM, Jeff Trawick wrote: > On Sun, Jun 9, 2013 at 5:57 AM, Stefan Fritsch wrote: > Hi, > > first of all, sorry that it took me so long to review at this. > > The current

Re: Revisiting the pre_htaccess hook

2013-06-27 Thread Stefan Fritsch
Jim Jagielski schrieb: >I like the idea as well... The only issue I see is wondering >if/when we'll have the implementation. > >On Jun 25, 2013, at 9:12 AM, Jeff Trawick wrote: > >> On Sun, Jun 9, 2013 at 5:57 AM, Stefan Fritsch >wrote: >> Hi, >> >> first of all, sorry that it took me so long t

Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-09 Thread Jeff Trawick
On Sun, Jun 9, 2013 at 8:00 AM, Steinar H. Gunderson wrote: > On Sun, Jun 09, 2013 at 11:57:54AM +0200, Stefan Fritsch wrote: > > Wouldn't a hook for opening the htaccess file make more sense because > > it would have more possible use cases? Then modules could use this > > hook to find htaccess

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-10 Thread Steinar H. Gunderson
On Tue, Jul 09, 2013 at 08:53:03AM -0400, Jeff Trawick wrote: > Do you have time to test with this patch on top of 2.4.x and report back? > > http://people.apache.org/~sf/open_htaccess_hook.patch Hi, I've tried this, adjusted mpm-itk, and it seems to work. Why do I need to return AP_DECLINED and

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-10 Thread Rainer Jung
On 10.07.2013 13:14, Steinar H. Gunderson wrote: > On Tue, Jul 09, 2013 at 08:53:03AM -0400, Jeff Trawick wrote: >> Do you have time to test with this patch on top of 2.4.x and report back? >> >> http://people.apache.org/~sf/open_htaccess_hook.patch > > Hi, > > I've tried this, adjusted mpm-itk,

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-10 Thread Stefan Fritsch
On Wednesday 10 July 2013, Steinar H. Gunderson wrote: > I don't like all that much having to duplicate the “official” hook > (in particular the ap_make_full_path() call), but I guess it's > better than what used to be there, and it's only two lines. Yes, that's the price to pay for the more flexi

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-10 Thread Jeff Trawick
On Wed, Jul 10, 2013 at 2:30 PM, Stefan Fritsch wrote: > On Wednesday 10 July 2013, Steinar H. Gunderson wrote: > > I don't like all that much having to duplicate the “official” hook > > (in particular the ap_make_full_path() call), but I guess it's > > better than what used to be there, and it's

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-22 Thread Steinar H. Gunderson
On Wed, Jul 10, 2013 at 03:07:56PM -0400, Jeff Trawick wrote: > I guess "it seems to work" in the earlier e-mail is the validation that the > API is sufficient for MPM-ITK. Hi, I see that 2.4.6 has been released, with no mention of open_htaccess in the source code. Was this reverted after 2.4.5?

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-24 Thread Stefan Fritsch
Am Montag, 22. Juli 2013, 19:58:11 schrieb Steinar H. Gunderson: > On Wed, Jul 10, 2013 at 03:07:56PM -0400, Jeff Trawick wrote: > > I guess "it seems to work" in the earlier e-mail is the validation > > that the API is sufficient for MPM-ITK. > I see that 2.4.6 has been released, with no mention

Re: Hey Steinar... Re: Revisiting the pre_htaccess hook

2013-07-24 Thread Jeff Trawick
On Wed, Jul 24, 2013 at 3:31 PM, Stefan Fritsch wrote: > Am Montag, 22. Juli 2013, 19:58:11 schrieb Steinar H. Gunderson: > > On Wed, Jul 10, 2013 at 03:07:56PM -0400, Jeff Trawick wrote: > > > I guess "it seems to work" in the earlier e-mail is the validation > > > that the API is sufficient for