Re: Some redundant code and comment typos in mod_remoteip

2013-12-13 Thread Marion & Christophe JAILLET
Not correct, this is just a french man who didn't take time to check in a dictionary... :) I update... Thx CJ Le 13/12/2013 19:57, Mike Rumph a écrit : equivalant versus equivalent Perhaps this is a difference in British versus American spelling, correct? Anyway, thanks for the commits

Re: Some redundant code and comment typos in mod_remoteip

2013-12-13 Thread Mike Rumph
equivalant versus equivalent Perhaps this is a difference in British versus American spelling, correct? Anyway, thanks for the commits. Mike Rumph On 12/12/2013 10:12 PM, Christophe JAILLET wrote: Trunk = r1550650 for comments upodate r1550651 for redundant check 2.4.x = r1550652 for

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread Christophe JAILLET
Trunk = r1550650 for comments upodate r1550651 for redundant check 2.4.x = r1550652 for comments upodate The other one will be proposed for backport with other easy patches to synch 2.4 and trunk in the coming days. BTW, for someone who has write access to APR tree, s/equivilant/equ

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread Mike Rumph
Just to make things easier here are the separate patches with your ideas included. Thanks, Mike Rumph On 12/12/2013 1:37 PM, Mike Rumph wrote: Hello Bill, Thanks for the advice. Leaving filename as is is okay for me, I just thought I saw it split at other places in the code comments. So sh

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread Mike Rumph
Hello Bill, Thanks for the advice. Leaving filename as is is okay for me, I just thought I saw it split at other places in the code comments. So should I resubmit the patch or is one of the committers okay with picking and choosing? The patch overall was just some small things that I noticed

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread William A. Rowe Jr.
On Thu, Dec 12, 2013 at 11:34 AM, William A. Rowe Jr. wrote: On Wed, 04 Dec 2013 11:25:32 -0800 Mike Rumph wrote: > > While researching mod_remoteip to work on httpd bugs 55635 and > > I noticed a few unrelated blemishes in mod_remoteip.c. > > These include some redundant code and comment typos.

Re: Some redundant code and comment typos in mod_remoteip

2013-12-12 Thread William A. Rowe Jr.
On Wed, 04 Dec 2013 11:25:32 -0800 Mike Rumph wrote: > While researching mod_remoteip to work on httpd bugs 55635 and 55637, > I noticed a few unrelated blemishes in mod_remoteip.c. > These include some redundant code and comment typos. > > The attached patch against httpd trunk should address t

Re: [PATCH]Some redundant code and comment typos in mod_remoteip

2013-12-10 Thread Mike Rumph
I forgot to add a [PATCH] tag on the front of the subject. The changes here are minor, but they do make the code a little cleaner. On 12/4/2013 11:25 AM, Mike Rumph wrote: While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes in mod_remoteip.c

Some redundant code and comment typos in mod_remoteip

2013-12-04 Thread Mike Rumph
While researching mod_remoteip to work on httpd bugs 55635 and 55637, I noticed a few unrelated blemishes in mod_remoteip.c. These include some redundant code and comment typos. The attached patch against httpd trunk should address these. Thanks, Mike Rumph Index: modules/metadata/mod_remoteip.