Re: Two questions on mod_ssl source code details

2015-05-26 Thread Rainer Jung
Am 22.05.2015 um 18:35 schrieb Yann Ylavic: On Fri, May 22, 2015 at 6:29 PM, Rainer Jung wrote: 1) In other code I see EC_KEY_free(ecdh); after EC_KEY *ecdh = EC_KEY_new_by_curve_name(...) and using ecdh, e.g. in SSL_CTX_set_tmp_ecdh(mctx->ssl_ctx, eckey); Should we add the free?

Re: Two questions on mod_ssl source code details

2015-05-22 Thread Rainer Jung
1) In other code I see EC_KEY_free(ecdh); after EC_KEY *ecdh = EC_KEY_new_by_curve_name(...) and using ecdh, e.g. in SSL_CTX_set_tmp_ecdh(mctx->ssl_ctx, eckey); Should we add the free? Or is it not needed? Anyone knows why? This was added in r1666363: * mod_ssl: fix small memory lea

Re: Two questions on mod_ssl source code details

2015-05-22 Thread Yann Ylavic
On Fri, May 22, 2015 at 6:29 PM, Rainer Jung wrote: > > 2) In modules/ssl/ssl_private.h I see > > /** > * The following features all depend on TLS extension support. > * Within this block, check again for features (not version numbers). > */ > #if !defined(OPENSSL_NO_TLSEXT) && defined(SSL_s

Re: Two questions on mod_ssl source code details

2015-05-22 Thread Yann Ylavic
On Fri, May 22, 2015 at 6:29 PM, Rainer Jung wrote: > 1) In other code I see > > EC_KEY_free(ecdh); > > after > > EC_KEY *ecdh = EC_KEY_new_by_curve_name(...) > and using ecdh, e.g. in > SSL_CTX_set_tmp_ecdh(mctx->ssl_ctx, eckey); > > Should we add the free? Or is it not needed? Anyone kno

Two questions on mod_ssl source code details

2015-05-22 Thread Rainer Jung
1) In other code I see EC_KEY_free(ecdh); after EC_KEY *ecdh = EC_KEY_new_by_curve_name(...) and using ecdh, e.g. in SSL_CTX_set_tmp_ecdh(mctx->ssl_ctx, eckey); Should we add the free? Or is it not needed? Anyone knows why? 2) In modules/ssl/ssl_private.h I see /** * The following