Use of brigade_split...

2005-02-18 Thread Paul Querna
First, let me say that apr_brigade_split is evil. It is used in several filters to break up input, or temporarily store some buckets. The problem is that it allocates a new brigade, commonly out of the request pool. This is fine, if you only call it once, but for streaming filters, where your

Re: Use of brigade_split...

2005-02-18 Thread Joe Orton
On Fri, Feb 18, 2005 at 01:12:52AM -0800, Paul Querna wrote: First, let me say that apr_brigade_split is evil. Specifically the combination of apr_brigade_split() and an apr_brigade_destroy() which is a noop, yes; #23567 is another example of a leak caused by this. I'd also concluded that

Re: Use of brigade_split...

2005-02-18 Thread Cliff Woolley
On Fri, 18 Feb 2005, Paul Querna wrote: First, let me say that apr_brigade_split is evil. It is used in several filters to break up input, or temporarily store some buckets. The problem is that it allocates a new brigade, commonly out of the request pool. Feel free to write a variant that