Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-11 Thread Akins, Brian
If anyone cares, here's how we do keys and vary in our cache: On store: Generate key: using url and r->args (we can ignore r->args per server, if needed) (http://www.domain.com/index.html?you=me) If(vary) { store the following info in meta file: cache_version_t - ala disk_cache (ours i

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-11 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Dirk-Willem van Gulik > Gesendet: Montag, 11. Februar 2008 13:12 > An: dev@httpd.apache.org > Betreff: Re: cache - cleaning up mod_memcache and making > other caches their live easier > > > On Feb 11, 2008, at 12:58

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-11 Thread Dirk-Willem van Gulik
On Feb 11, 2008, at 12:58 PM, Plüm, Rüdiger, VF-Group wrote: The contents of the cache is not protected by any means. So I do not see a security issue here. Somemone who has access to one cache entity has access to all. Agreed. But what I worry about is that you get some subtle interaction

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-11 Thread Plüm , Rüdiger , VF-Group
> -Ursprüngliche Nachricht- > Von: Dirk-Willem van Gulik > Gesendet: Montag, 11. Februar 2008 01:22 > An: dev@httpd.apache.org > Betreff: Re: cache - cleaning up mod_memcache and making > other caches their live easier > > > > > I currently do not un

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-10 Thread Dirk-Willem van Gulik
On Feb 10, 2008, at 10:45 PM, Ruediger Pluem wrote: 1. Some style nitpicks (especially indenting, sometimes typos in the comments) that make the patch sometimes hard to read. most files in cache seem out of sync with the .ident.pro file - so I guess I should do an reformat run. 3. Wh

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-10 Thread Graham Leggett
Dirk-Willem van Gulik wrote: Before I embark on an experiment (without much design/planning) -- any thoughts ? Or has someone already done most of this and/or designed it properly ? mod_disk_cache has certainly received more attention than the other modules, and can probably be considered th

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-10 Thread Ruediger Pluem
On 02/10/2008 05:39 PM, Dirk-Willem van Gulik wrote: See below for some aloud thinking -- note that this is not yet well thought out (all I did was try to minimize the overlap between disk_cache, memcached, distcache and some commercial thing -- and tried to move as much RFC2616 knowled

Re: cache - cleaning up mod_memcache and making other caches their live easier

2008-02-10 Thread Dirk-Willem van Gulik
On Feb 10, 2008, at 2:12 PM, Dirk-Willem van Gulik wrote: Right now (only) mod_disk_cache is doing the 'right(tm)' thing w.r.t. to Vary - the other caches (mod_memcache as part of the distribution and a handful of memcached, distcache and commercial cache modules) are just acting on the UR

cache - cleaning up mod_memcache and making other caches their live easier

2008-02-10 Thread Dirk-Willem van Gulik
Right now (only) mod_disk_cache is doing the 'right(tm)' thing w.r.t. to Vary - the other caches (mod_memcache as part of the distribution and a handful of memcached, distcache and commercial cache modules) are just acting on the URI (key). Bringing them in line involves a bit of cut-and-pa