This doesn't look right. Checking the notes table is a serious
performance hit, and why does it matter how many times keepalives
is incremented on an error path? There must be a better way to do this.
Roy
On Friday, August 27, 2004, at 04:44 PM, [EMAIL PROTECTED] wrote:
jim
Yeah, I am not keen on the notes table approach either. My original patch
to fix this didn't do that. Not that my patch was great either.
The problem with calling ap_set_keepalive() multiple times is that the
function doesn't just set the keepalive flag, it also increments the
connection's
On Fri, 27 Aug 2004 [EMAIL PROTECTED] wrote:
/*
+ * We need to ensure that r-connection-keepalive is valid in
+ * order to determine if we can discard the request body below.
+ */
+ap_set_keepalive(r);
I realize you probably just took my wording there, but it
WTF? -1 Jim, that code is doing an error check prior to the
strtol. It is not looking for the start of the number, but
ensuring that the number is non-negative and all digits prior
to calling the library routine. A simple check of *lenp would
have been sufficient for the blank case.
I need
While we are debating the best way to accomplish this Content-Length fix for the next
release, I kind of need to have it working for me right now in the current released
version. Therefore I've implemented this partial fix against 1.3.26 on my system:
root@nueva[391] pwd
Roy T. Fielding wrote:
WTF? -1 Jim, that code is doing an error check prior to the
strtol. It is not looking for the start of the number, but
ensuring that the number is non-negative and all digits prior
to calling the library routine. A simple check of *lenp would
have been
David Burry wrote:
While we are debating the best way to accomplish this Content-Length fix for the
next release, I kind of need to have it working for me right now in the current
released version. Therefore I've implemented this partial fix against 1.3.26 on my
system:
The current CVS
On Thu, Mar 21, 2002 at 02:49:47PM -, [EMAIL PROTECTED] wrote:
...
+++ http_protocol.c 21 Mar 2002 14:49:46 - 1.312
...
+/* keep a previously set server header (possible from proxy), otherwise
+ * generate a new server header */
+if (server =
On Tue, Jan 08, 2002 at 03:09:49PM -, [EMAIL PROTECTED] wrote:
-
r-assbackwards = (ll[0] == '\0');
r-protocol = ap_pstrdup(r-pool, ll[0] ? ll : HTTP/0.9);
-if (2 == sscanf(r-protocol, HTTP/%u.%u, major, minor)
- minor HTTP_VERSION(1,0))/* don't
