Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2004-08-24 Thread Mladen Turk
Justin Erenkrantz wrote: Modified:modules/proxy proxy_http.c Log: Use ap_str_tolower for lowercasing the scheme. That was the original intention (not apr_tolower). Can you please not mix formatting changes with code changes? Those spurious changes make it a lot tougher to review. Th

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2004-08-24 Thread Justin Erenkrantz
--On Tuesday, August 24, 2004 8:24 AM + [EMAIL PROTECTED] wrote: mturk 2004/08/24 01:24:18 Modified:modules/proxy proxy_http.c Log: Use ap_str_tolower for lowercasing the scheme. That was the original intention (not apr_tolower). Can you please not mix formatting changes with

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Brian Pane
Unless I'm missing something, this patch would make the proxy vulnerable to a DoS. An attacker could cause the httpd to buffer an arbitrarily large amount of data simply by sending an arbitrarily large request body, right? Brian On Tue, 2002-12-10 at 15:55, Bill Stoddard wrote: > Any objections

RE: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Bill Stoddard
> "Bill Stoddard" <[EMAIL PROTECTED]> writes: > > > Any objections to porting this to 2.0? > > > > Bill > > > > jerenkrantz2002/12/08 21:37:27 > > > > Modified:.CHANGES > >modules/proxy proxy_http.c > > Log: > > Rewrite how proxy sends its request to allow

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Paul J. Reder
Jeff Trawick wrote: "Bill Stoddard" <[EMAIL PROTECTED]> writes: Any objections to porting this to 2.0? Bill jerenkrantz2002/12/08 21:37:27 Modified:.CHANGES modules/proxy proxy_http.c Log: Rewrite how proxy sends its request to allow input bodies to morph

Re: FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-11 Thread Jeff Trawick
"Bill Stoddard" <[EMAIL PROTECTED]> writes: > Any objections to porting this to 2.0? > > Bill > > jerenkrantz2002/12/08 21:37:27 > > Modified:.CHANGES >modules/proxy proxy_http.c > Log: > Rewrite how proxy sends its request to allow input bodies to morph th

FW: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-12-10 Thread Bill Stoddard
Any objections to porting this to 2.0? Bill jerenkrantz2002/12/08 21:37:27 Modified:.CHANGES modules/proxy proxy_http.c Log: Rewrite how proxy sends its request to allow input bodies to morph the request bodies. Previously, if an input filter changed the r

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-11-08 Thread Justin Erenkrantz
--On Friday, November 08, 2002 12:25:20 -0800 Brian Pane <[EMAIL PROTECTED]> wrote: put it. We don't necessarily want to reset the request Content-Length whenever we create a subrequest, because somebody might have a legitimate need to read the form post data within a server-side-included subreq

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-11-08 Thread Brian Pane
I agree: it probably should be at a higher level. For now, I made the change as localized as possible, in order to get the proxy problem fixed quickly without breaking anything else. But eventually the fix should probably be in the core. The only problem is that I'm not sure where it's safe to pu

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-11-08 Thread William A. Rowe, Jr.
It seems like this patch should be at a higher level. Don't we also have problems with POST to any other sort of included subrequest being transformed into a GET but retaining the content-length or other irrelevant (nasty) headers? Is there a more appropriate place to make this correction for

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-11-08 Thread Jim Jagielski
[EMAIL PROTECTED] wrote: > > When doing a GET of a proxied URL as a subrequest within > a POSTed request, don't send the original POST's Content-Length > as part of the header for the GET. > Good catch! I was puzzling over some weird crud I was seeing and this nailed it. --

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2002-04-01 Thread Graham Leggett
[EMAIL PROTECTED] wrote: > Log: > ap_proxy_http_request needs to check the return status of ap_pass_brigade Does the same problem exist in proxy_ftp? Regards, Graham -- - [EMAIL PROTECTED]"There's a moon

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2001-11-18 Thread Justin Erenkrantz
On Sun, Nov 18, 2001 at 04:59:38PM -, [EMAIL PROTECTED] wrote: > ianh01/11/18 08:59:38 > > Modified:modules/proxy proxy_http.c > Log: > Add extra If-XXX request headers to be ignored in subrequests > Allow cache-control header to get passed to subrequests > tabs -> space

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2001-11-18 Thread Ian Holsman
Graham Leggett wrote: > [EMAIL PROTECTED] wrote: > > >> p_conn->close += ap_proxy_liststr(apr_table_get(r->headers_in, >>"Connection"), >> > "close"); > >> +/* sub-requests never use keepalives */ >> +if (r->main) { >> +

Re: cvs commit: httpd-2.0/modules/proxy proxy_http.c

2001-11-18 Thread Graham Leggett
[EMAIL PROTECTED] wrote: >p_conn->close += ap_proxy_liststr(apr_table_get(r->headers_in, > "Connection"), "close"); > +/* sub-requests never use keepalives */ > +if (r->main) { > +p_conn->close++; > +} >