Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-28 Thread Bill Stoddard
On Sat, Apr 27, 2002 at 07:30:51PM -0700, Justin Erenkrantz wrote: +qi = apr_palloc(pool, sizeof(*qi)); +memset(qi, 0, sizeof(*qi)); As we said, if you are concerned about the performance aspect of apr_pcalloc, then we should fix apr_pcalloc NOT attempt to work

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Justin Erenkrantz
Comments inline. On Sun, Apr 28, 2002 at 01:45:00AM -, [EMAIL PROTECTED] wrote: 1.16 +108 -0httpd-2.0/server/mpm/worker/fdqueue.c Index: fdqueue.c === RCS file:

Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Aaron Bannert
On Sat, Apr 27, 2002 at 07:30:51PM -0700, Justin Erenkrantz wrote: +qi = apr_palloc(pool, sizeof(*qi)); +memset(qi, 0, sizeof(*qi)); As we said, if you are concerned about the performance aspect of apr_pcalloc, then we should fix apr_pcalloc NOT attempt to work around its

Re: More worker ideas Re: cvs commit: httpd-2.0/server/mpm/worker worker.c fdqueue.c fdqueue.h

2002-04-27 Thread Aaron Bannert
On Sat, Apr 27, 2002 at 07:39:24PM -0700, Brian Pane wrote: I was going to complain about the addition of yet another mutex to the critical path of request processing, but it got me thinking about an approach to making worker faster: shorten the time spent in the mutex-protected region. Yes!