Re: cvs commit: httpd-2.0/server request.c

2002-12-13 Thread Francis Daly
On Thu, Dec 12, 2002 at 11:31:44AM -0500, Paul J. Reder wrote: [EMAIL PROTECTED] wrote: wrowe 2002/12/11 23:05:54 Modified:server request.c Log: Make the code simpler to follow, and perhaps clear up the follow-symlink bug reports we have seen on bugzilla.

Re: cvs commit: httpd-2.0/server request.c

2002-12-12 Thread Paul J. Reder
[EMAIL PROTECTED] wrote: wrowe 2002/12/11 23:05:54 Modified:server request.c Log: Make the code simpler to follow, and perhaps clear up the follow-symlink bug reports we have seen on bugzilla. e.g. 14206 etc. Revision ChangesPath 1.122 +23 -43

Re: cvs commit: httpd-2.0/server request.c

2002-11-01 Thread Greg Stein
On Fri, Nov 01, 2002 at 03:27:20AM -, [EMAIL PROTECTED] wrote: ... +++ request.c 1 Nov 2002 03:27:20 - 1.118 @@ -924,6 +924,8 @@ /* That temporary trailing slash was useful, now drop it. */ if (temp_slash) { +

Re: cvs commit: httpd-2.0/server request.c

2002-11-01 Thread Jeff Trawick
William A. Rowe, Jr. [EMAIL PROTECTED] writes: Folks, this looks wrong after consideration. If someone is familiar with the Linux gcc optimizer, please see my last comments in http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14147 I'm starting to feel like the optimizer bit us. That

Re: cvs commit: httpd-2.0/server request.c

2002-11-01 Thread Jeff Trawick
Greg Stein [EMAIL PROTECTED] writes: On Fri, Nov 01, 2002 at 03:27:20AM -, [EMAIL PROTECTED] wrote: ... +++ request.c 1 Nov 2002 03:27:20 - 1.118 @@ -924,6 +924,8 @@ /* That temporary trailing slash was useful, now drop it. */

Re: cvs commit: httpd-2.0/server request.c

2002-10-31 Thread William A. Rowe, Jr.
Folks, this looks wrong after consideration. If someone is familiar with the Linux gcc optimizer, please see my last comments in http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14147 I'm starting to feel like the optimizer bit us. Bill At 09:27 PM 10/31/2002, [EMAIL PROTECTED] wrote: wrowe

Re: cvs commit: httpd-2.0/server request.c

2002-10-25 Thread Jeff Trawick
[EMAIL PROTECTED] writes: Index: request.c === RCS file: /home/cvs/httpd-2.0/server/request.c,v retrieving revision 1.115 retrieving revision 1.116 diff -u -u -r1.115 -r1.116 --- request.c 5 Sep 2002

Re: cvs commit: httpd-2.0/server request.c

2002-05-11 Thread William A. Rowe, Jr.
My gut instinct? You break something here. ap_location_walk, IIRC, sets up the default_conf. Which means the default_conf may not be brought in - given the case you've optimized for here. I might be mistaken, and don't have the energy to research this early morning, but I thought I better

Re: cvs commit: httpd-2.0/server request.c

2002-05-11 Thread Brian Pane
William A. Rowe, Jr. wrote: My gut instinct? You break something here. ap_location_walk, IIRC, sets up the default_conf. Which means the default_conf may not be brought in - given the case you've optimized for here. I might be mistaken, and don't have the energy to research this early

Re: cvs commit: httpd-2.0/server request.c

2001-11-09 Thread Bill Stoddard
the filepath_merge or is this something required on Windows (in which case perhaps the results can be cached). Bill - Original Message - From: William A. Rowe, Jr. [EMAIL PROTECTED] To: [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Friday, November 09, 2001 11:30 AM Subject: Re: cvs commit: httpd-2.0/server

Re: cvs commit: httpd-2.0/server request.c

2001-09-30 Thread Ryan Morgan
On Sat, Sep 29, 2001 at 09:26:47AM -0700, Justin Erenkrantz wrote: On Sat, Sep 29, 2001 at 12:01:33PM -0400, Cliff Woolley wrote: On 29 Sep 2001 [EMAIL PROTECTED] wrote: if (strncmp(rnew-filename, fdir, fdirlen) == 0 rnew-filename[fdirlen] -

Re: cvs commit: httpd-2.0/server request.c

2001-08-30 Thread Cliff Woolley
On 31 Aug 2001 [EMAIL PROTECTED] wrote: Assuming that's a correct translation, which I believe to be the case (and which also seems to jive with the previous version of the test), then that first part darned well better check == 0, as opposed to != 0. strncmp returns 0 when they